Do this for all mozilla-central based builds. Do this before pushing bug 604266, to be sure the latter won't break these builds. *** I would suggest to start with /buildbot-configs/mozilla2/win64/tryserver/xulrunner/mozconfig * line 9 -- ac_add_options --disable-installer which was added in the meantime (bug 567154).

This bug seems to be mostly affecting XulRunner.

If 'ac_add_options --disable-installer' can't be "removed" from 'mozconfig', then it should be "replaced" with 'MOZ_INSTALLER=' in 'confvars.sh'. In the latter case, this bug depends on bug 661403.

(In reply to Serge Gautherie (:sgautherie) from comment #2) > If 'ac_add_options --disable-installer' can't be "removed" from 'mozconfig', > then it should be "replaced" with 'MOZ_INSTALLER=' in 'confvars.sh'. Ted, which way should this be done? > In the latter case, this bug depends on bug 661403. Blocking bugs have been fixed.

I'm not sure why that needs --disable-installer at all. Can we find out if that build works fine without it?

Comment on attachment 572200 [details] [diff] [review] 'ac_add_options --disable-installer' removal, mozilla-central part Review of attachment 572200 [details] [diff] [review]: ----------------------------------------------------------------- Did you test or Try this patch? Which repository are these paths in? (Is it 'build'?) ::: mobile/config/mozconfigs/macosx-desktop/nightly @@ -5,5 @@ > . $topsrcdir/build/macosx/mozconfig.leopard > ac_cv_visibility_pragma=no > > ac_add_options --disable-install-strip > -ac_add_options --disable-installer This one should probably be part of bug 697150.

>>>>Which repository are these paths in? (Is it 'build'?) >>>>::: mobile/config/mozconfigs/macosx-desktop/nightly mobile is inside src directory(the source code which i downloaded using command "hg clone http://hg.mozilla.org/mozilla-central/ src")

Comment on attachment 572200 [details] [diff] [review] 'ac_add_options --disable-installer' removal, mozilla-central part Like bug 697150 this should be reviewed by a peer of the Build Config module. I don't personally know if windows xulrunner builds will be OK without --disable-installer. We don't normally call 'make installer' on the tinderbox machines, just 'make sdk' and 'make package', so it's possible something in http://mxr.mozilla.org/mozilla-central/source/xulrunner/installer/windows/Makefile.in is broken now.

(In reply to Abhishek Singh from comment #7) > command "hg clone http://hg.mozilla.org/mozilla-central/ src") Ah, right: I didn't know about these 3 m-c files. http://mxr.mozilla.org/mozilla-central/search?string=--disable-installer&case=1&find=%2Fconfig%2Fmozconfigs%2F

Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)

The patch doesn't apply anymore. mobile/config/... is now mobile/xul/config/...

See comment 11.

(In reply to Ed Morley [:edmorley] from comment #15) This bug is not fixed yet: see URL.

buildbot-configs are redundant with in-tree mozconfigs, surely?

(In reply to Ed Morley [:edmorley] from comment #17) > buildbot-configs are redundant with in-tree mozconfigs, surely? Could very much be, but I didn't follow closely what happened wrt both places/uses. If buildbot-configs/* files are redundant/obsolete, then they should just be removed.

catlee, what about comment 18 after bug 558180?

(In reply to Serge Gautherie (:sgautherie) from comment #19) > catlee, what about comment 18 after bug 558180? Yes, after 558180 is closed those files can be removed. Right now some are used, some aren't.

(In reply to Chris AtLee [:catlee] from comment #20) > Yes, after 558180 is closed those files can be removed. Then I would think the current bug is (still) valid as is: in one place or the other, this option needs to be removed eventually.

V.Fixed, per MXR search.