Closed Bug 650398 Opened 14 years ago Closed 14 years ago

Remove inheritance class in favor of prototypal inheritance

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files, 2 obsolete files)

Update API modules to use the prototype inheritance v2 [checked-in]
(deleted), patch
gmealer
: review+
Details | Diff | Splinter Review
UI classes -> prototype style
(deleted), patch
whimboo
: review+
Details | Diff | Splinter Review
We have to remove the external inheritance.js module and update all of our classes to use prototypal inheritance scheme. I will have the module ready in a couple of minutes.
Attached patch Inheritance module [checked-in] (obsolete) (deleted) — — Splinter Review
New prototypal based inheritance module. Setting r+ based on inspection from Geo over my shoulders.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #526399 - Flags: review+
Comment on attachment 526399 [details] [diff] [review] Inheritance module [checked-in] Module landed as: https://github.com/geoelectric/mozmill-api-refactor/commit/977698a5aa1cb648e7b0ae6d520c955471220066
Attachment #526399 - Attachment description: Inheritance module → Inheritance module [checked-in]
Chiming in to confirm I r+'d in person.
Attachment #526426 - Flags: review?(gmealer)
Comment on attachment 526399 [details] [diff] [review] Inheritance module [checked-in] That patch is busted. Check the real changeset for details.
Attachment #526399 - Attachment is obsolete: true
Missed a small piece which the throws method would have been caught. Once this is in I will backport the throws/doesNotThrow stuff.
Attachment #526426 - Attachment is obsolete: true
Attachment #526426 - Flags: review?(gmealer)
Attachment #526430 - Flags: review?(gmealer)
Comment on attachment 526430 [details] [diff] [review] Update API modules to use the prototype inheritance v2 [checked-in] Looks great! r+
Attachment #526430 - Flags: review?(gmealer) → review+
Comment on attachment 526430 [details] [diff] [review] Update API modules to use the prototype inheritance v2 [checked-in] Landed as: https://github.com/geoelectric/mozmill-api-refactor/commit/ced3c2719ab0abd797dae9f99c059f3321aef206
Attachment #526430 - Attachment description: Update API modules to use the prototype inheritance v2 → Update API modules to use the prototype inheritance v2 [checked-in]
Comment on attachment 526450 [details] [diff] [review] UI classes -> prototype style Looks good. But please make sure to also delete the old inheritance module when you land this patch.
Attachment #526450 - Flags: review?(hskupin) → review+
Didn't think to collapse the commits, so ended up pushing two. Landed as https://github.com/geoelectric/mozmill-api-refactor/commit/aeb89c721b969f7c746baa38ad8fdcf513049755 (original patch) + https://github.com/geoelectric/mozmill-api-refactor/commit/a733546974a8e4e769aef66df994c0a3025734ae (remove external/inheritance.js)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: