Closed Bug 652056 Opened 14 years ago Closed 13 years ago

two minor improvements to cycle collector dumps

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files, 1 obsolete file)

patch 1: get better JSTracer data
(deleted), patch
Details | Diff | Splinter Review
patch 2: allow much longer urls
(deleted), patch
peterv
: review+
mccr8
: checkin+
Details | Diff | Splinter Review
patch 3: make XPCOM_CC_DRAW_GRAPHS work at shutdown too
(deleted), patch
peterv
: review+
mccr8
: checkin+
Details | Diff | Splinter Review
During the debugging session described in http://groups.google.com/group/mozilla.dev.platform/msg/d84ea7e1219d71a0 I wrote two patches to fix things that we ran into during that session. (I still need to test them...)
Now that JSTracer is binary-compatible between opt and debug, we should no longer need these ifdefs, and we can get better data in opt builds when WantDebugInfo is set.
Attached patch patch 2: allow much longer urls (deleted) — — Splinter Review
We needed the full URLs but couldn't get to them.
Here's a third one that's older and that I have tested. I don't feel like filing a separate bug for it. This makes XPCOM_CC_DRAW_GRAPHS apply to the shutdown collections too.
Attachment #527732 - Flags: review?(peterv)
Attached patch peterv's CC shutdown logging patch (obsolete) (deleted) — — Splinter Review
Peterv sent me this patch for CC shutdown logging. Basically the same, but factored a bit differently. Just some food for thought.
Attachment #527732 - Flags: review?(peterv) → review+
Comment on attachment 527731 [details] [diff] [review] patch 2: allow much longer urls Well, I finally got around to testing these other 2 in opt builds. This patch definitely works; I can't find any evidence of the other one doing so, though.
Attachment #527731 - Flags: review?(peterv)
Attachment #527731 - Flags: review?(peterv) → review+
Attachment #527731 - Flags: checkin+
Attachment #527732 - Flags: checkin+
Attachment #527839 - Attachment is obsolete: true
dbaron, you could probably close this. 2 of 3 patches landed, and the JSTracer stuff in part 1 is going to require additional futzing with the JS engine, so I'll deal with that in its own bug, bug 701415.
Sounds good. (And yes, I didn't land patch 1 because it didn't actually do anything useful.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: