Be careful here, xpinstall/packager is most certainly not dead.

This moves the UI pieces from toolkit/mozapps/xpinstall into toolkit/mozapps/extensions. No point in having these separate really.

This moves the packaging code from xpinstall/packager to toolkit/mozapps/installer

This removes the remains of xpinstall from the tree

Comment on attachment 528622 [details] [diff] [review] remove xpinstall Dan, all this code is no longer in use so this just removes it from the tree

Comment on attachment 528621 [details] [diff] [review] move xpinstall/packager to toolkit/mozapps/installer Let's get Kyle's review for the packager changes as well

Comment on attachment 528621 [details] [diff] [review] move xpinstall/packager to toolkit/mozapps/installer Looks fine... still want khuey r+ before landing.

Comment on attachment 528620 [details] [diff] [review] move toolkit/mozapps/xpinstall Would be nice to get the other places in the repos that reference xpinstallConfirm.xul updated as well. http://mxr.mozilla.org/mozilla-central/source/xulrunner/app/xulrunner.js#43 http://mxr.mozilla.org/comm-central/source/calendar/sunbird/app/profile/sunbird.js#101

Dan, any chance of getting the final sign off to remove all this code?

Brian and I think this does not block "switch to pkix by default", but it should be fixed soon; moving it to a tracker bug for major PKIX related issues.

Jorge, I was going to land the reviewed pieces of this soon but they have some extension impact. They will move a bunch of UI and locale files from chrome://mozapps/xxx/xpinstall/ to chrome://mozapps/xxx/extensions/. I wanted to hear if you thought that would be a particular issue for extension compatibility since it is also possible to just leave them in the same chrome locations (though it would certainly be cleaner and more logical to move them since we're moving the files)

The impact is significant, affecting roughly 50 add-ons on AMO: https://mxr.mozilla.org/addons/search?string=%2Fxpinstall%2F&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=addons I see some of them point to DTD files, which could break the add-on or Firefox badly. I'd recommend to keep the chrome paths intact, or at least have a deprecation period where both paths work and an error is shown in the Error Console for using the old ones.

This is an updated patch that does the file moves but leaves the chrome locations for all the files the same so it shouldn't break extensions

Comment on attachment 576633 [details] [diff] [review] move toolkit/mozapps/xpinstall All of the changes look sane though I didn't look very hard.

Comment on attachment 576633 [details] [diff] [review] move toolkit/mozapps/xpinstall also need to update toolkit-makefiles.sh

bah, please fix this too + \ No newline at end of file

Landed the reviewed patches on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e620a0c5b5 https://hg.mozilla.org/integration/mozilla-inbound/rev/79b80511d577 https://hg.mozilla.org/integration/mozilla-inbound/rev/e5229443d6a2

Bleh and https://hg.mozilla.org/integration/mozilla-inbound/rev/5e2bfc3905cb

https://hg.mozilla.org/mozilla-central/rev/c7e620a0c5b5 https://hg.mozilla.org/mozilla-central/rev/79b80511d577 https://hg.mozilla.org/mozilla-central/rev/e5229443d6a2 https://hg.mozilla.org/mozilla-central/rev/5e2bfc3905cb

attachment 528622 [details] [diff] [review] doesn't seem to have landed yet.

Comment on attachment 528622 [details] [diff] [review] remove xpinstall Review of attachment 528622 [details] [diff] [review]: ----------------------------------------------------------------- r=dveditz

Final patch is on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d5aa2c53f04