Closed
Bug 652381
Opened 14 years ago
Closed 14 years ago
The "Show Votes" page is completely broken
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
VERIFIED
FIXED
Bugzilla 4.0
People
(Reporter: rbgray, Assigned: LpSolit)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
strikethrough on resolved bug
Visiting the Show Votes page for a resolved bug displays a page with strikethrough on most of the text. This seems to be a regression from previous Bugzilla behavior.
Running: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3
|
||
Comment 1•14 years ago
|
||
The page generated for id=voting/bug.html has:
> <span class="bz_closed"><a href="show_bug.cgi?id=652351"...
before the DOCTYPE; with no closing span tag; which is presumably why the strikethrough goes crazy.
|
Assignee | |
Comment 2•14 years ago
|
||
Things are even worse in Bugzilla 4.1.1. We broke it upstream.
Assignee: nobody → ui
Severity: normal → major
Component: Bugzilla: Other b.m.o Issues → User Interface
Product: mozilla.org → Bugzilla
QA Contact: other-bmo-issues → default-qa
Target Milestone: --- → Bugzilla 4.0
Version: other → 4.0
|
|
Assignee | |
Updated•14 years ago
|
Flags: blocking4.0.1+
Summary: Show Votes page for resolved bug has massive strikethrough → The "Show Votes" page is completely broken
|
|
Assignee | |
Updated•14 years ago
|
Depends on: bz-plugin-vote
|
|
Assignee | |
Comment 3•14 years ago
|
||
You cannot pass "FILTER ..." within [% PROCESS global/header.html.tmpl %]. You have to do it in two steps. I also added the bug summary to the page header, to make things easier to discover (this way, you don't need to hover the bug ID to discover what the bug is about).
|
||
Comment 4•14 years ago
|
||
Comment on attachment 527997 [details] [diff] [review]
patch, v1
Review of attachment 527997 [details] [diff] [review]:
Looks good to me.
Attachment #527997 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Updated•14 years ago
|
Flags: approval4.0+
Flags: approval+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7783.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
Committed revision 7574.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 6•14 years ago
|
||
This has been merged and pushed to production on bmo.
|
||
Comment 7•14 years ago
|
||
VERIFIED on bmo production. The massive strikethrough has disappeared in the "Show Votes" pages for all resolved bugs that I checked.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•