Closed
Bug 652399
Opened 13 years ago
Closed 13 years ago
Using system libjpeg should disable building embedded libjpeg-turbo
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla7
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
cf. summary
Attachment #527985 -
Flags: review?(ted.mielczarek)
|
||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
|
||
Comment 1•13 years ago
|
||
Comment on attachment 527985 [details] [diff] [review]
Patch
Review of attachment 527985 [details] [diff] [review]:
r=me
Attachment #527985 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
I don't know how I thought the previous patch was okay, but it turns out MOZ_LIBJPEG_TURBO is set to 1 unconditionally after it was set to nothing by the patch, so it was pointless.
Attachment #527985 -
Attachment is obsolete: true
Attachment #529453 -
Flags: review?(ted.mielczarek)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 529453 [details] [diff] [review]
Patch v2
Review of attachment 529453 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #529453 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
||
Comment 5•13 years ago
|
||
Backed out on beta (FF6), a=legneato, due to bug 675568.
http://hg.mozilla.org/releases/mozilla-beta/rev/f83956d23621
Target Milestone: mozilla6 → mozilla7
|
|
||
Comment 6•13 years ago
|
||
The push from comment 5 was to the relbranch, not the default branch. Properly backed out on beta: http://hg.mozilla.org/releases/mozilla-beta/rev/eeabcaa28b68
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•