Closed Bug 652501 Opened 14 years ago Closed 14 years ago

Make reftests that cause plugin crashes clean up their minidumps

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla6

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(2 files)

There are some reftests that deliberately cause a plugin crash, resulting in the test suite harness flagging them as errors (if there happened to be at least one reftest failure in the test run). The reftest harness should be able to remove the minidumps if an individual test indicates that it will be crashing a plugin. (Bug 642175 handles the same thing for mochitests.)
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 528080 [details] [diff] [review] Part 1: Allow reftests to clean up plugin and IPC process crash dumps Review of attachment 528080 [details] [diff] [review]: ::: layout/tools/reftest/reftest.js @@ +1448,5 @@ } +function OnProcessCrashed(subject, topic, data) +{ + netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect"); You don't need enablePrivilege here, this code runs as chrome.
Comment on attachment 528080 [details] [diff] [review] Part 1: Allow reftests to clean up plugin and IPC process crash dumps Review of attachment 528080 [details] [diff] [review]: Looks good!
Attachment #528080 - Flags: review?(roc) → review+
Comment on attachment 528081 [details] [diff] [review] Part 2: Make existing plugin crash reftests clean up after themselves Review of attachment 528081 [details] [diff] [review]:
Attachment #528081 - Flags: review?(roc) → review+
Comment on attachment 528080 [details] [diff] [review] Part 1: Allow reftests to clean up plugin and IPC process crash dumps Please document this in layout/tools/reftest/README.txt
Lnaded http://hg.mozilla.org/mozilla-central/rev/1cc4d287d0b8 addressing Ted's and David's comments.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Blocks: 588608
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: