Closed Bug 65262 Opened 24 years ago Closed 24 years ago

fix bookmarks and history window size/pos/state persistence

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: danm.moz, Assigned: danm.moz)

References

Details

Attachments

(1 file)

People aren't going to let me close bug 32148 until I make the bookmarks and history windows comply. Attached is a patch for that. It adds persistence of sizemode to bm-find.xul and history.xul, removes their (not-working) dependence on persisting |x| and |y| attributes (should be screenX/Y, and it's all automated, so they need do nothing special), and removes the |centerscreen| attribute from all the window.open calls (that I could find) that refence them. That last bit is necessary because |centerscreen| overrides the restoration of position memory.
Attached patch fix (deleted) — Splinter Review
Blocks: 32148
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
looks innocent, enough, r=pchen
sr=mscott do we need any more changes like this in mail too?
Checked in. No one is bugging me about adding zoom state persistence for any other window. But here's a current list of windows that take the trouble to persist position but not zoom state. Many of them are things like dialogs for which it doesn't make sense to persist zoom state. But the list is worth looking at: ./editor/ui/composer/content/TextEditorAppShell.xul ./editor/ui/dialogs/content/EdImageMap.xul ./editor/ui/dialogs/content/EdInsertTable.xul ./extensions/wallet/editor/WalletViewer.xul ./mailnews/base/prefs/resources/content/AccountManager.xul ./mailnews/base/resources/content/mail3PaneWindowVertLayout.xul ./mailnews/base/resources/content/subscribe.xul ./mailnews/base/search/resources/content/FilterEditor.xul ./mailnews/base/search/resources/content/SearchDialog.xul ./xpfe/browser/resources/content/openLocation.xul ./xpfe/components/console/resources/content/console.xul ./xpfe/components/filepicker/res/content/filepicker.xul ./xpfe/components/find/resources/finddialog.xul ./xpfe/components/prefwindow/resources/content/pref.xul ./xpfe/components/sidebar/resources/customize.xul ./xpfe/components/ucth/resources/helperAppLauncher.xul ./xpfe/global/resources/content/unix/printdialog.xul ain't gonna stop me from closing this bug, though.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
cc'ing claudius so he can check bookmarks/history [if i don't get to it before he does]. cc'ing nbaca wrt mscott's question above.
checked the bookmarks and history windows using 2001.02.09.08 comm bits. what's rather bizarre here is that size and position are remembered on winNT and Mac, but only size is remembered on linux. no sure if this is expected behavior in linux, however [wm foo?]. if it is, or should be a seperate bug, do re-resolve this bug. thx.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
QA Contact: sairuh → claudius
*** Bug 55692 has been marked as a duplicate of this bug. ***
Oh that. Yes, that's a known issue for Linux. It's expected behaviour, and there's no bug that I know of. Certainly no open one. Linux windows are placed initially by the window manager, and we explicitly don't attempt to override it. Re-resolving fixed.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31. if you think this particular bug is not fixed, please make sure of the following before reopening: a. retest with a *recent* trunk build. b. query bugzilla to see if there's an existing, open bug (new, reopened, assigned) that covers your issue. c. if this does need to be reopened, make sure there are specific steps to reproduce (unless already provided and up-to-date). thanks! [set your search string in mail to "AmbassadorKoshNaranek" to filter out these messages.]
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: