Closed Bug 652976 Opened 14 years ago Closed 9 years ago

[css3-animations] warning "should already have refreshed style rule" with SVG animation and CSS animation

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jruderman, Assigned: dbaron)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase (crashes Firefox when loaded)
(deleted), image/svg+xml
Details
stack trace
(deleted), text/plain
Details
change NS_ABORT_IF_FALSE to NS_WARN_IF_FALSE
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached image testcase (crashes Firefox when loaded) (deleted) —
###!!! ABORT: should already have refreshed style rule: 'ea->mStyleRuleRefreshTime == mPresContext->RefreshDriver()->MostRecentRefresh()', file layout/style/nsAnimationManager.cpp, line 835
Attached file stack trace (deleted) —
I'm inclined to just merge GetAnimationRule and CheckAnimationRule (with the name GetAnimationRule, but the contents of CheckAnimationRule with GetAnimationRule merged in to it). I think the assertion should probably just go.
This assertion was just checking correctness, and in the cases we're seeing it I think there's not a correctness bug, just a performance problem in that we redo work (since we sometimes do style reresolution during a refresh driver notification prior to notifying the animation manager).
Attachment #539362 - Flags: review?(bzbarsky)
Comment on attachment 539362 [details] [diff] [review] change NS_ABORT_IF_FALSE to NS_WARN_IF_FALSE r=me
Attachment #539362 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/405374f8075e (which does NOT make this bug fixed)
Severity: critical → normal
Summary: [css3-animations] "ABORT: should already have refreshed style rule" with SVG animation and CSS animation → [css3-animations] warning "should already have refreshed style rule" with SVG animation and CSS animation
Pushed: http://hg.mozilla.org/mozilla-central/rev/405374f8075e
Assignee: nobody → dbaron
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Target Milestone: mozilla7 → ---
Testcase no longer warns on trunk.
Status: NEW → RESOLVED
Closed: 14 years ago → 9 years ago
Flags: in-testsuite+
Resolution: --- → WORKSFORME
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: