Closed
Bug 652982
Opened 14 years ago
Closed 11 years ago
[READY] test_close_on_last_window.xul needs to be explicit about its timeout requirements
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: ehsan.akhgari, Assigned: Felipe)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
See the discussion in bug 544356 comment 56 onwards.
|
Reporter | |
Comment 1•14 years ago
|
||
What should happen here is that the test should call SimpleTest.requestFlakyTimeout with a reason parameter, stating why it's necessary for this to use setTimeout with a non-zero timeout value. See bug 649012's dependency list for some examples. The function call should look something like:
SimpleTest.requestFlakyTimeout("This test should use timeouts because...");
Simple as that! :-)
|
Assignee | |
Comment 2•14 years ago
|
||
There we go, thanks for the explanation.
hg export'ed to make it easier in case you want to land this together with the SimpleTest patch from bug 649012.
I guess a rubberstamp for this is enough?
Assignee: nobody → felipc
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 528789 [details] [diff] [review]
Patch
(In reply to comment #2)
> There we go, thanks for the explanation.
Thanks for writing this patch.
> hg export'ed to make it easier in case you want to land this together with the
> SimpleTest patch from bug 649012.
Great. Indeed, this needs to land with everything else in bug 649012.
> I guess a rubberstamp for this is enough?
It should be. r=me to make it explciit. :-)
Attachment #528789 -
Flags: review+
|
|
Reporter | |
Updated•14 years ago
|
Summary: test_close_on_last_window.xul needs to be explicit about its timeout requirements → [READY] test_close_on_last_window.xul needs to be explicit about its timeout requirements
|
|
Reporter | |
Comment 4•11 years ago
|
||
Landed with the wrong bug number: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee4ee2b72573
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/47079c098699
Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c3cd34ca884
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•