User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0 Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0 I am in tab group A. I open a new tab and type in a partial URL. I select the option to "Switch to Tab" which is already open in Tab Group B. After jumping to Tab Group B, I immediately hit Cmd-T to open a new tab. This switches me back to Tab Group A and opens a new tab there. Reproducible: Always Steps to Reproduce: Note: I have 14 separate tab groups open when I do this. 1. Create two tab groups: A) www.google.com, notepad.yahoo.com B) espn.com 2. Go to tab group B. 3. Cmd-T 4. Type: "notepad" 5. Select "Switch to Tab" - this jumps you to Tab Group A 6. Cmd-T again - this jumps you back to Tab Group B Actual Results: The new tab was created in the wrong tab group. Expected Results: The new tab should have been created in the tab group which I was using at the time.

Confirmed on Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110427 Firefox/6.0a1 Pressing Ctrl+T in Step 5, open a new tab in Tab Group B instead of Tab Group A.

Confirmed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110428 Firefox/6.0a1 Setting resolution to NEW

Regression range Works on: Mozilla/5.0 (Windows NT 5.1; rv:2.0b10pre) Gecko/20110113 Firefox/4.0b10pre http://hg.mozilla.org/mozilla-central/rev/54184cfa6f0e Doesn't work on: Mozilla/5.0 (Windows NT 5.1; rv:2.0b10pre) Gecko/20110114 Firefox/4.0b10pre http://hg.mozilla.org/mozilla-central/rev/9f412256da4c Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=54184cfa6f0e &tochange=9f412256da4c

Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110828 Firefox/9.0a1 This issue is also reproducible in Ubuntu 11.04.

This only happens if you use switch-to-tab from a blank tab. So from looking at Vlads regression range, could it be bug 588265? Also see bug 555767

basically just a guess, but seems to work for me

Comment on attachment 564872 [details] [diff] [review] patch v1 Review of attachment 564872 [details] [diff] [review]: ----------------------------------------------------------------- Tim is leading reviews at this point.

Comment on attachment 564872 [details] [diff] [review] patch v1 Review of attachment 564872 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for your patch! That's indeed a regression of bug 555767 and bug 588265. Alas, your patch makes our tests fail because we rely on the closed tab's group being activated even when automatically closed. We'd need to set a flag before .removeTab() here... https://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#297 I'll be happy to review your patch again! ::: browser/base/content/tabview/groupitems.js @@ +1093,5 @@ > > if (dontArrange) > this._freezeItemSize(count); > > + if (this._children.length > 0 && this._activeTab && tabItem.closedManually) ... and then we should check here if the flag from urlbarBindings.xml is set.