js> (123456789).toExponential() "1.23456789e+8" js> (123456789).toExponential(undefined) "1e+8" The second value is incorrect per ES5 15.7.4.6.

I was going to explain why this is a [good first bug], but it's a one-line change so it's faster to just fix it myself. Patch tomorrow.

Jandem, I'm pretty sure you won't know what that one-line fix is, anymore, but maybe you can find out, again?

Simply change `if (args.length() == 0)` to `if (!args.hasDefined(0))` in num_toExponential_impl. For bonus points improve overall spec compliance, e.g. `Infinity.toExponential(Infinity)` should return Infinity instead of throwing a RangeError. And remove dead code in num_toPrecision_impl, the `if (args.length() == 0){...}` branch will never be true.

Thanks, that's very helpful! André, don't you sometimes get an itch, you know, where you just *know* you want to write a patch? ;)

Not exactly "tomorrow", but here's a patch. This also removes the dead branch André noticed in num_toPrecision_impl. > For bonus points improve overall spec compliance, e.g. > `Infinity.toExponential(Infinity)` should return Infinity instead of > throwing a RangeError. That's not as trivial and I don't really have the time to fix this. But I can file a follow-up bug for it.

Comment on attachment 8340004 [details] [diff] [review] Patch Review of attachment 8340004 [details] [diff] [review]: ----------------------------------------------------------------- Nice. Not that this particular test really contains anything copyrightable, but I *do* like the idea of having license headers in all test files. Ideally just Public Domain, IMO.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b58f32ae7646 (In reply to Till Schneidereit [:till] from comment #6) > Not that this particular test really contains anything copyrightable, but I > *do* like the idea of having license headers in all test files. Ideally just > Public Domain, IMO. We add a ton of jit-tests, a lot of them from fuzzers, and IMO it seems overkill to add license headers to all of them..