Closed
Bug 654225
Opened 13 years ago
Closed 8 years ago
::-moz-focus-inner should not affect layout of containing element
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: zwol, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
It seems logical that a <button> with -moz-appearance:none and padding:0 should be laid out exactly the same as a <span> with display:inline-block (see attached test case). But unless you also specify button::-moz-focus-inner { padding: 0; border: none } you get extra inner padding on the <button>. The extra rule is undesirable because it's using undocumented internal-UA-sheet magic and because it has the side effect of removing the button's focus ring entirely. There should be *default* extra padding on a -moz-appearance:none <button> so that the focus ring does not *by default* collide with the text; however, all of that padding should be reflected in forms.css's specification of the padding: property of the <button> itself, so that it can all be removed without resorting to undocumented internal magic. (This comes up when you're trying to make some <a>s look exactly like <button>s on the same page.)
Comment 1•13 years ago
|
||
Probably a duplicate, but in any case... We should just use outline drawing here, imo, not a border. Or something.
Comment 2•13 years ago
|
||
In particular, looks like a duplicate of bug 140562.
Reporter | ||
Comment 3•13 years ago
|
||
I almost said "we should do this with an outline" in the original description but then wasn't sure if that would have any other consequences. (Particularly, *can* you put an outline on the inside of a box?) If that's right, then yeah, duplicate of 140562.
Comment 4•13 years ago
|
||
> Particularly, *can* you put an outline on the inside of a box?
Yes; in particular you could use a negative outline-offset.
Comment 5•13 years ago
|
||
Though we would just want to draw an outline around the stuff in the middle there, not try to guess the offset from the button outer edge.
Comment 11•8 years ago
|
||
This has been fixed by bug 140562's patches.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•