Closed
Bug 654653
Opened 14 years ago
Closed 14 years ago
Some CXXFLAGS is missing for non GNU_CXX compiler
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
In Bug 650304, CXXFLAGS is setting to $_SAVE_CXXFLAGS if ac_cv_have_usable_char16_t is not "yes".
But _SAVE_CXXFLAGS is only set for GNU_CXX before the checking.
It will wash away some CXXFLAGS.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 529937 [details] [diff] [review]
patch
Review of attachment 529937 [details] [diff] [review]:
::: configure.in
@@ +2983,5 @@
if test "$ac_cv_have_usable_char16_t" = "yes"; then
AC_DEFINE(HAVE_CPP_CHAR16_T)
HAVE_CPP_CHAR16_T=1
else
+ if test "$GNU_CXX"; then
r=me with an "elif" instead of "else if" (and thus, one less "fi")
Attachment #529937 -
Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•