Josh Matthews [:jdm] Assignee
	Description • 13 years ago

+++ This bug was initially created as a clone of Bug #600677 +++

Tom van Cutsem 2011-04-28 06:30:07 PDT

The current patch doesn't seem to fix the issue for function proxies:

Testcase:
var handler = {
  get: function(rcvr, name) {
    if (name === 'isTrapping') return true;
  },
  fix: function() {
    return {
      isTrapping: { value: false }
    };
  }
};

var p = Proxy.createFunction(handler, function(){}, function(){});
assert(p.isTrapping);
Object.preventExtensions(p);
assert(! p.isTrapping);

The call to preventExtensions still fails. It works fine for object proxies
though (replace Proxy.createFunction by Proxy.create)

	Josh Matthews [:jdm] Assignee
	Comment 1 • 13 years ago

Ok, this gets the the correct results for p.isTrapping for both checks in Tom's testcase.  However, I'm worried about this output from the same test:

>js> Object.preventExtensions(p)
>Function.prototype.toString called on incompatible object

Is this something I need to be investigating, or is this separate bug fodder?

	Tom Van Cutsem
	Comment 2 • 13 years ago

That seems odd. It seems Function.prototype.toString is incompatible with fixed function proxies?

On non-fixed function proxies |fp| with call trap argument |ct|, |Function.prototype.toString.call(fp)| is equivalent to |Function.prototype.toString.call(ct)|

This behavior should remain the same for fixed function proxies.

	David Bruant
	Comment 3 • 12 years ago

Marking this bug as invalid since there is no fix trap with the direct proxies design.
Feel free to change the status if I'm mistaken.