Closed
Bug 655517
Opened 13 years ago
Closed 13 years ago
Remove nsIDOMDocumentEvent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
ehsan.akhgari
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #530872 -
Flags: review?(Olli.Pettay)
Flags: in-testsuite-
|
Assignee | |
Updated•13 years ago
|
Attachment #530872 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 530872 [details] [diff] [review]
Patch v1
> #define DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocument) \
>- DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentEvent) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentStyle) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSDocumentStyle) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMDocumentXBL) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMNSEventTarget) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMEventTarget) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOM3Node) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMXPathEvaluator) \
> DOM_CLASSINFO_MAP_ENTRY(nsIDOMNodeSelector)
Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
Could you either fix that here, of file a followup bug.
>@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
> in nsIDOMNodeFilter filter,
> in boolean entityReferenceExpansion)
> raises(DOMException);
> nsIDOMTreeWalker createTreeWalker(in nsIDOMNode root,
> in unsigned long whatToShow,
> in nsIDOMNodeFilter filter,
> in boolean entityReferenceExpansion)
> raises(DOMException);
>+
>+ nsIDOMEvent createEvent(in DOMString eventType)
>+ raises(DOMException);
Although the change may be binary compatible, I'd like to see iid updated.
Update also all the interfaces which inherit nsIDOMDocument.
Attachment #530872 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to comment #1)
> Comment on attachment 530872 [details] [diff] [review] [review]
> Patch v1
>
> Strange that DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES doesn't have nsIDOMDocument.
> Could you either fix that here, of file a followup bug.
Filed bug 655598.
> >@@ -128,9 +129,12 @@ interface nsIDOMDocument : nsIDOMNode
> > in nsIDOMNodeFilter filter,
> > in boolean entityReferenceExpansion)
> > raises(DOMException);
> > nsIDOMTreeWalker createTreeWalker(in nsIDOMNode root,
> > in unsigned long whatToShow,
> > in nsIDOMNodeFilter filter,
> > in boolean entityReferenceExpansion)
> > raises(DOMException);
> >+
> >+ nsIDOMEvent createEvent(in DOMString eventType)
> >+ raises(DOMException);
> Although the change may be binary compatible, I'd like to see iid updated.
> Update also all the interfaces which inherit nsIDOMDocument.
Will do.
|
||
Updated•13 years ago
|
Attachment #530872 -
Flags: review?(ehsan) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [needs landing]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla6
Keywords: dev-doc-complete
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•