Closed
Bug 655588
Opened 14 years ago
Closed 14 years ago
Desaturating filter produces more realistic grey scale than colour averaging
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: neil, Assigned: neil)
References
Details
(Whiteboard: [bugday-20110513])
Attachments
(1 file)
|
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
The Add-Ons manager uses a colour averaging filter to grey scale disable icons. However the most common strategy (as used by my paint package and also apparently GIMP, according to Wikipedia) is to match the luminance of the grey scale image to that of the colour image. This is most readily achieved through the use of the saturating SVG filter to completely desaturate the image.
|
Assignee | |
Comment 1•14 years ago
|
||
Also with dos2unix line ending conversion...
|
||
Comment 2•14 years ago
|
||
Comment on attachment 530920 [details] [diff] [review]
Proposed patch
Makes sense :)
Attachment #530920 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed changeset 388cde12c89d to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 4•14 years ago
|
||
Looks pretty nice with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110512 Firefox/6.0a1.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla6
|
|
||
Updated•14 years ago
|
Whiteboard: [bugday-20110513]
|
|
||
Comment 5•14 years ago
|
||
Oh, and I don't think there is a need for tests.
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•