Closed
Bug 656488
Opened 13 years ago
Closed 13 years ago
Command-H to hide app doesn't work when in Panorama
Categories
(Firefox Graveyard :: Panorama, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 7
People
(Reporter: erik, Assigned: raymondlee)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
When in Panorama mode, hitting command-H doesn't hide Aurora. The application menu blinks, but nothing else happens. Selecting Hide Aurora with the mouse does work.
|
||
Updated•13 years ago
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #534995 -
Attachment is obsolete: true
Attachment #534995 -
Flags: feedback?(tim.taubert)
Attachment #535264 -
Flags: feedback?(tim.taubert)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 535264 [details] [diff] [review]
v2
Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #535264 -
Flags: feedback?(tim.taubert) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #535264 -
Flags: review?(ian)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 535264 [details] [diff] [review]
v2
Review of attachment 535264 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/tabview/ui.js
@@ +1034,5 @@
> function processBrowserKeys(evt) {
> + // let any keys with alt to pass through
> + if (evt.altKey)
> + return;
> +
With this, do we still need the special treatment for hideThisAppCmdMac?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to comment #4)
> Comment on attachment 535264 [details] [diff] [review] [review]
> v2
>
> Review of attachment 535264 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
>
> ::: browser/base/content/tabview/ui.js
> @@ +1034,5 @@
> > function processBrowserKeys(evt) {
> > + // let any keys with alt to pass through
> > + if (evt.altKey)
> > + return;
> > +
>
> With this, do we still need the special treatment for hideThisAppCmdMac?
yes, we do. hideThisAppCmdMac => cmd/ctrl + H. We don't need special treatment for hideOtherAppsCmdMac => cmd/ctrl + alt + H
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 535264 [details] [diff] [review]
v2
Passed Try
http://tbpl.mozilla.org/?tree=Try&rev=fd16aca86305
|
|
Assignee | |
Comment 9•13 years ago
|
||
Updated it to work with the latest trunk. Trivial patch.
Attachment #535264 -
Attachment is obsolete: true
Attachment #535264 -
Flags: review?(ian)
Attachment #537067 -
Flags: review?(ian)
|
|
||
Comment 10•13 years ago
|
||
Comment on attachment 537067 [details] [diff] [review]
v2.1
Review of attachment 537067 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good
Attachment #537067 -
Flags: review?(ian) → review+
|
|
Assignee | |
Comment 11•13 years ago
|
||
Attachment #537067 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 12•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 5 → Firefox 7
|
||
Comment 13•13 years ago
|
||
Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a1) Gecko/20110609 Firefox/7.0a1.
Pressing Command + H while in Panorama hides Firefox - problem no longer exists. Setting status to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•