Serge Gautherie (:sgautherie) Assignee
	Description • 13 years ago

Firefox 6 and SeaMonkey 2.2 (at least) report
{
Warning: package error or possible missing or unnecessary file: bin/components/content_xmldoc.xpt (package-manifest, 75).
-bin/components/content_xmldoc.xpt

Warning: package error or possible missing or unnecessary file: bin/components/dom_views.xpt (package-manifest, 103).
-bin/components/dom_views.xpt

Warning: package error or possible missing or unnecessary file: bin/components/services-crypto.xpt (package-manifest, 164).
-bin/components/services-crypto.xpt

Warning: package error or possible missing or unnecessary file: bin/components/webshell_idls.xpt (package-manifest, 192).
-bin/components/webshell_idls.xpt

Warning: package error or possible missing or unnecessary file: bin/components/nsMicrosummaryService.js (package-manifest, 270).
-bin/components/nsMicrosummaryService.js
}

NB: SeaMonkey 2.0 (at least) does not report these.

	Phil Ringnalda (:philor)
	Comment 1 • 13 years ago

Until bug 526333 lands, there is no Core packaging, only copy-pasted per-app manifests. Filed bug 657252 for Fx (and bug 657251 on the one of those five which is an actual Core issue) on the assumption you'd rather use your bug for SM.

	Serge Gautherie (:sgautherie) Assignee
	Comment 2 • 13 years ago

(In reply to comment #1)

Thanks.

	Serge Gautherie (:sgautherie) Assignee
	Comment 3 • 13 years ago

This (= bug 457102) applies to mozilla5 too.

	Serge Gautherie (:sgautherie) Assignee
	Comment 4 • 13 years ago

webshell_idls.xpt part (= bug 571685) applies to mozilla5 too.

	Justin Wood (:Callek)
	Comment 5 • 13 years ago

Comment on attachment 532596 [details] [diff] [review]
(Bv1) Stop packaging dead dom_views.xpt, services-crypto.xpt, webshell_idls.xpt and nsMicrosummaryService.js, except on MOZILLA_5_0_BRANCH (= Port bug 657252)

I was delaying reviewing due to the branch divergence since we were setting up the comm-aurora/beta branches.

If you need divergence, please create new patches, comm-beta == Mozilla 5 atm, and a skim here means this won't be needed there at all, but could land for aurora and central

	Serge Gautherie (:sgautherie) Assignee
	Comment 6 • 13 years ago

Comment on attachment 532568 [details] [diff] [review]
(Av1) Stop packaging dead content_xmldoc.xpt (= Port bug 657251)
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/8b4036c5e3aa

	Serge Gautherie (:sgautherie) Assignee
	Comment 7 • 13 years ago

Comment on attachment 532568 [details] [diff] [review]
(Av1) Stop packaging dead content_xmldoc.xpt (= Port bug 657251)
[Checked in: Comment 6]

"approval-comm-aurora=?":
Zero risk, not "required", but as well fix this along patch B.

	Serge Gautherie (:sgautherie) Assignee
	Comment 8 • 13 years ago

Bv1, with comment 5 suggestion(s).

"approval-comm-aurora=?":
Zero risk, removed-files.in part (at least) "wanted".

	Serge Gautherie (:sgautherie) Assignee
	Comment 9 • 13 years ago

(In reply to comment #5)
> comm-beta == Mozilla 5
> atm, and a skim here means this won't be needed there at all

I confirm no need (= too late) to bother with the 2 parts that would have been nice to have wrt moz5/comm-beta :-|

	Justin Wood (:Callek)
	Comment 10 • 13 years ago

Comment on attachment 535976 [details] [diff] [review]
(Bv2) Stop packaging dead dom_views.xpt, services-crypto.xpt, webshell_idls.xpt and nsMicrosummaryService.js (= Port bug 657252), Remove an obsolete MOZILLA_5_0_BRANCH check
[Checked in: Comment 11]

rs+=me

	Serge Gautherie (:sgautherie) Assignee
	Comment 11 • 13 years ago

Comment on attachment 535976 [details] [diff] [review]
(Bv2) Stop packaging dead dom_views.xpt, services-crypto.xpt, webshell_idls.xpt and nsMicrosummaryService.js (= Port bug 657252), Remove an obsolete MOZILLA_5_0_BRANCH check
[Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/abd07d9a9ac8

	Philip Chee
	Comment 12 • 13 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1306765441.1306768000.12808.gz

TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js | Could not get microsummary service

You forgot to fix the test when you removed the microsummary service.

	Philip Chee
	Comment 13 • 13 years ago

Please back out this line:
-@BINPATH@/components/nsMicrosummaryService.js
As it will be removed in the patch for Bug 659277.

	Philip Chee
	Comment 14 • 13 years ago

Pushed backout patch to comm-central rs=Callek.
http://hg.mozilla.org/comm-central/rev/357b0810c427

	Philip Chee
	Comment 15 • 13 years ago

Missed one more line:
http://hg.mozilla.org/comm-central/rev/6d8bcd20f245

	Serge Gautherie (:sgautherie) Assignee
	Comment 16 • 13 years ago

(In reply to comment #12)

> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1306765441.1306768000.
> 12808.gz

"WINNT 5.2 comm-central-trunk debug test xpcshell on 2011/05/30 07:24:01"

> TEST-UNEXPECTED-FAIL |
> e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/
> test_bookmarks_html.js | Could not get microsummary service
> 
> You forgot to fix the test when you removed the microsummary service.

I understand but I disagree: this test was already failing before I began to check in.
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1306714817.1306716245.21131.gz
WINNT 5.2 comm-central-trunk debug test xpcshell on 2011/05/29 17:20:17


(In reply to comment #14)
> Pushed backout patch to comm-central rs=Callek.

Re-adding packager lines isn't doing any good: nsMicrosummaryService.js simply doesn't exist anymore in the first place.
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1306794428.1306795009.25302.gz
Linux comm-central-trunk debug test xpcshell on 2011/05/30 15:27:08


Then: I fully support bug 659277, but please revert your useless backouts here.
I verified that my changesets fixed what they were meant to.

	Philip Chee
	Comment 17 • 13 years ago

> Then: I fully support bug 659277, but please revert your useless backouts here.
> I verified that my changesets fixed what they were meant to.
Bug 659277 will remove those lines anyway so reverting these will just be unnecessary work.

	Philip Chee
	Comment 18 • 13 years ago

Sorry for jumping the gun on this.

	Serge Gautherie (:sgautherie) Assignee
	Comment 19 • 13 years ago

Apology accepted.

	Serge Gautherie (:sgautherie) Assignee
	Comment 20 • 13 years ago

(In addition to previous comment)

Ftr, merge history for these 2(+2) patches:

http://hg.mozilla.org/releases/comm-aurora/pushloghtml?changeset=8b4036c5e3aa
bugzilla@standard8.plus.com
Tue Jul 05 14:01:26 2011 -0700	48fcd0e54208
(See AURORA_BASE_20110705 tag)

http://hg.mozilla.org/releases/comm-beta/pushloghtml?changeset=8b4036c5e3aa
bugzilla@standard8.plus.com
Tue Aug 16 14:25:04 2011 -0700	6970c86be3cd
(See BETA_BASE_20110816 and AURORA_7_END tags)

http://hg.mozilla.org/releases/comm-release/pushloghtml?changeset=8b4036c5e3aa
bugzilla@standard8.plus.com
Thu Sep 22 13:32:28 2011 -0700	fbc1a9b3e5e5
(See RELEASE_BASE_20110922 tag and lots of previous ones)

Which was included in
"at Thu Sep 22 22:35:55 2011 -0700	SEAMONKEY_2_4_RELEASE"