Closed
Bug 657215
Opened 13 years ago
Closed 13 years ago
No search engine selected in Internet Search preferences on new profile
Categories
(SeaMonkey :: Search, defect)
SeaMonkey
Search
Tracking
(blocking-seamonkey2.1 -, seamonkey2.1 wanted)
RESOLVED
FIXED
seamonkey2.1final
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-seamonkey2.1+
|
Details | Diff | Splinter Review |
The Internet search preference panel fails to show any search engine as selected if the search engine preference is still at its default setting. This is because the preference is actually a localised string.
For some reason bug 410613 deleted the wrong lines when removing the "defaultengine" preference, thus incorrectly changing the type of the "defaultenginename" preference.
|
Assignee | |
Comment 1•13 years ago
|
||
The real change is the letter w, which tells prefwindow.xml that this is a localised string.
The appendChild call is unnecessary because appendItem already calls it.
The value set is unnecessary because prefwindow.xml already sets it. (In fact this automatic value set is what exposes the bug.)
|
||
Comment 2•13 years ago
|
||
Dupe of bug 624829 (or vice-versa) I guess.
|
||
Updated•13 years ago
|
blocking-seamonkey2.1: --- → ?
Attachment #532515 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Pushed changeset e8332e7c3d7c to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 5•13 years ago
|
||
I want this if we end up doing a respin, not respinning for it alone though.
blocking-seamonkey2.1: ? → -
status-seamonkey2.1:
--- → wanted
|
|
||
Updated•13 years ago
|
Target Milestone: --- → seamonkey2.2
|
|
||
Updated•13 years ago
|
Attachment #532515 -
Flags: approval-seamonkey2.1?
Attachment #532515 -
Flags: approval-seamonkey2.1? → approval-seamonkey2.1+
|
|
||
Comment 7•13 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•