Closed
Bug 657219
Opened 14 years ago
Closed 14 years ago
Intermittent timeout in browser/base/content/test/tabview/browser_tabview_undo_group.js
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 7
People
(Reporter: ttaubert, Assigned: raymondlee)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
Reporter | ||
Updated•14 years ago
|
Reporter | ||
Updated•14 years ago
|
Assignee: tim.taubert → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 3•14 years ago
|
||
Based on the link in comment 0, the previous test is still running after finish() is called which might be the cause of the problem.
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3) > Created attachment 536231 [details] [diff] [review] [review] > v1 > > Based on the link in comment 0, the previous test is still running after > finish() is called which might be the cause of the problem. Passed Try: http://tbpl.mozilla.org/?tree=Try&rev=7febbe87498d
Reporter | ||
Comment 5•14 years ago
|
||
Comment on attachment 536231 [details] [diff] [review] v1 Review of attachment 536231 [details] [diff] [review]: ----------------------------------------------------------------- For some reason Utils.log() is used instead of SimpleTest.info() and the first seems to have buffering enabled so that the console message output is slightly delayed. If you exchange that with info() it's perfectly in line. The test is actually failing here: > let closeButton = groupItem.container.getElementsByClassName("close"); > ok(closeButton, "Group item close button exists"); > EventUtils.sendMouseEvent({ type: "click" }, closeButton[0], contentWindow); So maybe we should add a waitForFocus() call for the contentWindow here after the tabview is shown. Alas, I can't see anything obviously intermittent...
Attachment #536231 -
Flags: feedback?(tim.taubert) → feedback-
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #536231 -
Attachment is obsolete: true
Attachment #536282 -
Flags: feedback?(tim.taubert)
Reporter | ||
Comment 7•14 years ago
|
||
Comment on attachment 536282 [details] [diff] [review] v2 Review of attachment 536282 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/tabview/browser_tabview_startup_transitions.js @@ +42,5 @@ > + > + tabViewWindow.document.removeEventListener( > + "transitionend", onTransitionEnd, false); > + > + win.close(); Nit: Please add "registerCleanupFunction(function () win.close())" instead of this line to ensure the window gets closed when timing out.
Attachment #536282 -
Flags: feedback?(tim.taubert) → feedback+
Assignee | ||
Comment 8•14 years ago
|
||
Attachment #536282 -
Attachment is obsolete: true
Attachment #536318 -
Flags: review?(ian)
Comment 9•14 years ago
|
||
Comment on attachment 536318 [details] [diff] [review] v3 Review of attachment 536318 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #536318 -
Flags: review?(ian) → review+
Reporter | ||
Comment 11•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/316299946b8f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Reporter | ||
Comment 12•13 years ago
|
||
Adding intermittent test failures to new meta bug. (bugspam)
Blocks: 665844
Comment 13•13 years ago
|
||
Setting status to verified fixed based on the results in: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314769105.1314770462.11076.gz.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•