Closed
Bug 657343
Opened 13 years ago
Closed 13 years ago
Vertical misalignment of message headers which don't have an associated link
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(seamonkey2.2 fixed, seamonkey2.3 fixed)
VERIFIED
FIXED
seamonkey2.2
People
(Reporter: rsx11m.pub, Assigned: neil)
References
Details
(Keywords: polish, regression)
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mnyromyr
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
I assumed this had been filed already since it has been there for a while, but didn't find anything, thus filing it now. The headers in both the 3-pane and the stand-alone mail window have a noticeable vertical shift between header name and header value. If the header value(s) is/are linkified the alignment is correct.
I'm seeing this on different machines (Windows XP and Windows 7) with both the Windows Classic and Windows 7 default desktop themes. It's not an issue with SeaMonkey 2.0, thus a regression.
Screenshot follows.
Message-header pane with 300% zoom and pixel-grid overlay. This is Windows 7 using the Windows Classic desktop theme, SeaMonkey default theme. ClearType is disabled and gfx.direct2d.disabled set "true" to avoid font smoothing and thus to get a clear measure. Using the Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20110511 SeaMonkey/2.1 release candidate build #2.
As can be seen, header values which contain a link (blue color) are aligned correctly, whereas plain entries (Subject, Date, Received) are misaligned by being consistently 3px too low.
Also reproducible on Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110511 SeaMonkey/2.1 using KDE4. I'm seeing 3px as well for the default theme, however only a 2px mismatch with the modern theme. So that's slightly different.
OS: Windows 7 → All
Hardware: x86 → All
Assignee | ||
Comment 4•13 years ago
|
||
This was changed by bug 481751 (see comment 14 in particular). In our case there's a bottom margin on the label which has the effect of stretching the textbox. Prior to bug 481751 the text was (usually) top aligned so the effect wasn't noticeable. Now the text is vertically centred.
Blocks: 481751
Assignee | ||
Comment 5•13 years ago
|
||
This adds headerValueBox elements to the XBL bindings that don't already have it, and ensures that all the headerValueBox elements have align and flex.
Neil, is this the right patch? It adds CSS rules for #search-button only...
Assignee | ||
Comment 7•13 years ago
|
||
Sorry, I attached the patch for bug 653743 by mistake...
Attachment #534334 -
Attachment is obsolete: true
Attachment #534334 -
Flags: review?(mnyromyr)
Attachment #534335 -
Flags: review?(mnyromyr)
Updated•13 years ago
|
Attachment #534335 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 8•13 years ago
|
||
Pushed changeset 422b90f25878 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•13 years ago
|
||
Comment on attachment 534335 [details] [diff] [review]
Proposed patch [Checked in: trunk Comment 8, aurora/beta Comment 11]
Fairly simple regression fix, no l10n impact.
Attachment #534335 -
Flags: approval-comm-beta?
Attachment #534335 -
Flags: approval-comm-aurora?
Comment 10•13 years ago
|
||
Comment on attachment 534335 [details] [diff] [review]
Proposed patch [Checked in: trunk Comment 8, aurora/beta Comment 11]
a=me
Attachment #534335 -
Flags: approval-comm-beta?
Attachment #534335 -
Flags: approval-comm-beta+
Attachment #534335 -
Flags: approval-comm-aurora?
Attachment #534335 -
Flags: approval-comm-aurora+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing comm-aurora, comm-beta]
Comment 11•13 years ago
|
||
Comment on attachment 534335 [details] [diff] [review]
Proposed patch [Checked in: trunk Comment 8, aurora/beta Comment 11]
http://hg.mozilla.org/releases/comm-aurora/rev/24d3702c1ba6
http://hg.mozilla.org/releases/comm-beta/rev/0c7f86ea92f7
Attachment #534335 -
Attachment description: Proposed patch → Proposed patch [Checked in: trunk Comment 8, aurora/beta Comment 11]
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [needs landing comm-aurora, comm-beta]
Target Milestone: --- → seamonkey2.2
Reporter | ||
Comment 12•13 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110609 SeaMonkey/2.4a1 trunk nightly build. Looks good, thanks!
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
status-seamonkey2.2:
--- → fixed
status-seamonkey2.3:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•