Open
Bug 658068
Opened 13 years ago
Updated 2 years ago
Properly escape spaces in title= in atom links displayed by buglist.cgi
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
NEW
People
(Reporter: dkl, Unassigned)
References
Details
(Whiteboard: [bmo4.0-resolved])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
Patch attached that properly escapes spaces in the title= variable in the atom links displayed on buglist.cgi. This fixes some HTML validation issues pointed out by bug 652413.
Attachment #533424 -
Flags: review?(LpSolit)
Reporter | ||
Updated•13 years ago
|
Severity: normal → minor
OS: Mac OS X → All
Hardware: x86 → All
Comment 1•13 years ago
|
||
Comment on attachment 533424 [details] [diff] [review]
Patch to escape spaces in title= in the atom links of buglist.cgi (v1)
wrong patch!
Attachment #533424 -
Flags: review?(LpSolit) → review-
Reporter | ||
Comment 2•13 years ago
|
||
Ugh, Sorry. Here is the right patch with just the one file in question.
dkl
Attachment #533424 -
Attachment is obsolete: true
Attachment #533434 -
Flags: review?(LpSolit)
Comment 3•13 years ago
|
||
Comment on attachment 533434 [details] [diff] [review]
Patch to escape spaces in title= in the atom links of buglist.cgi (v2)
>- atomlink = "buglist.cgi?$urlquerypart&title=$title&ctype=atom"
>+ atomlink = "buglist.cgi?$urlquerypart&title=$url_filtered_title&ctype=atom"
atomlink is already HTML-filtered in global/header.html.tmpl:
[% IF atomlink %]
<link rel="alternate"
type="application/atom+xml" title="Atom feed"
href="[% atomlink FILTER html %]">
[% END %]
so your change is wrong.
Attachment #533434 -
Flags: review?(LpSolit) → review-
Reporter | ||
Comment 4•13 years ago
|
||
Not the way I understood the issue. The HTML validation service is complaining that the 'title' attribute has spaces in it which should instead be %20. The html filter does not convert spaces to anything but the uri filter does. That is why the patch uri filters the title only. The html filter in header.html.tmpl will handle everything else.
dkl
Reporter | ||
Updated•13 years ago
|
Whiteboard: [bmo4.0-resolved]
Reporter | ||
Updated•2 years ago
|
Assignee: dkl → ui
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•