Closed Bug 658087 Opened 13 years ago Closed 11 years ago

Make TabChild be quiet

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: stechz, Assigned: evilpie)

References

Details

Attachments

(1 file, 2 obsolete files)

It's printfing all over the place!
Attached patch Make TabChild be quiet (obsolete) (deleted) — Splinter Review
Attachment #533444 - Flags: review?(Olli.Pettay)
Attached patch Make TabChild be quiet (obsolete) (deleted) — Splinter Review
Compile issues on Windows
Attachment #533684 - Flags: review?(Olli.Pettay)
Attachment #533444 - Attachment is obsolete: true
Attachment #533444 - Flags: review?(Olli.Pettay)
Comment on attachment 533684 [details] [diff] [review]
Make TabChild be quiet

Is anyone going to use log which just prints "creating ..." and "loading..."?

Would it make sense to put those printfs just inside #ifdef DEBUG?
I just want them hidden by default, debug and optimized. Perhaps remove them if they aren't useful to anyone?
Comment on attachment 533684 [details] [diff] [review]
Make TabChild be quiet

So unless there is some good use case for the log, I'd prefer
#ifdef DEBUG
Attachment #533684 - Flags: review?(Olli.Pettay) → review-
(In reply to comment #5)
> Comment on attachment 533684 [details] [diff] [review] [review]
> Make TabChild be quiet
> 
> So unless there is some good use case for the log, I'd prefer
> #ifdef DEBUG

Again, I don't want these logs on debug builds either.
At least, not enabled by default.
I can't imagine these printfs being useful to anyone anymore.  Some of them were added for debugging purposes during the initial e10s sprint in 2009 ...
I think now that we have e10s for thumbs we should really fix this logging in release builds.
Blocks: core-e10s
Attached patch remove-log (deleted) — Splinter Review
I don't think these log message are helpful in any way, so we might as well remove them.
Assignee: nobody → evilpies
Attachment #533684 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #794127 - Flags: review?(bugs)
Attachment #794127 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/4d2adaf69288
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: