Closed
Bug 658383
Opened 14 years ago
Closed 14 years ago
Location bar "Go" button is not subject to the javascript: URL security changes in bug 656433
Categories
(Firefox :: Address Bar, defect)
Tracking
()
VERIFIED
FIXED
Firefox 6
People
(Reporter: jruderman, Assigned: Gavin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
(split from bug 658220)
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 533818 [details] [diff] [review]
patch
>+ function loadCurrent(url, postData) {
>+ // Pass LOAD_FLAGS_DISALLOW_INHERIT_OWNER to prevent any loads from
>+ // inheriting the currently loaded document's principal.
>+ let flags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP |
>+ Ci.nsIWebNavigation.LOAD_FLAGS_DISALLOW_INHERIT_OWNER;
>+ gBrowser.loadURIWithFlags(url, flags, null, null, postData);
>+ }
>+ loadCurrent(url, postData);
>+ loadCurrent(url, postData);
It looks like url and postData are already in loadCurrent's scope and don't need to be passed in.
Attachment #533818 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #533818 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite+
Target Milestone: --- → Firefox 6
|
||
Comment 5•13 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20100101 Firefox/6.0
Verified issue on Mac OS X 10.6. "Go" button is no longer a subject to the javascript: URL.
Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•