Closed Bug 658849 Opened 14 years ago Closed 14 years ago

"WARNING: Failed to create timer: [...]/nsJSEnvironment.cpp, line 3387" spammed at least 4 times on shutdown

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(2 files, 1 obsolete file)

WARNING: Failed to create timer: file /scratch/work/builds/mozilla-central/mozilla-central.10-10-08.07-25/mozilla/dom/base/nsJSEnvironment.cpp, line 3387 STEPS TO REPRODUCE: 1. Start debug build of firefox. 2. Quit. ACTUAL RESULTS: At least 4 instances of this warning will be the last thing you see in your terminal output: > WARNING: Failed to create timer: file mozilla/dom/base/nsJSEnvironment.cpp, line 3387 This affects both a just-created profile as well as profile that I've used for a bit. Snippet of source that's involved here: > 3376 void > 3377 nsJSContext::PokeCC() > 3378 { [...] > 3384 CallCreateInstance("@mozilla.org/timer;1", &sCCTimer); > 3385 > 3386 if (!sCCTimer) { > 3387 NS_WARNING("Failed to create timer"); > 3388 return; > 3389 } http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.cpp#3375 I'm guessing the timer-creation is failing because we're in XPCOM shutdown...?
The warning was added just a few months ago, actually. Flagging as blocking the bug that added it, on the assumption that this has been happening since then.
Blocks: 630932
Yeah, we should probably just remove the NS_WARNING.
Attached patch fix (deleted) — Splinter Review
Here's a patch to remove the warning (and replace it with an explanatory comment).
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #535774 - Flags: review?(gal)
Attachment #535774 - Flags: review?(gal) → review+
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
d'oh, I missed that there are two copies of this same warning -- one in PokeGC (fixed by already-checked-in-patch), and another one in PokeCC. So, we still spam this on shutdown, from PokeCC. Patch coming up to silence that one, too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch followup: also fix PokeCC (deleted) — Splinter Review
Attachment #536485 - Flags: review?(gal)
Attachment #536485 - Flags: review?(gal) → review+
Whiteboard: fixed-in-cedar
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Attached image Firefox start error (obsolete) (deleted) —
Comment on attachment 555054 [details] Firefox start error (I don't believe comment 11 is related to this bug at all. --> Obsoleting the screenshot attached therein.)
Attachment #555054 - Attachment is obsolete: true
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: