Closed
Bug 659332
Opened 13 years ago
Closed 9 years ago
trailing // should disappear if input text is something like "filxxxx" in the LocationBar
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: alice0775, Assigned: ventnor.bugzilla)
References
Details
(Keywords: dogfood, regression)
Attachments
(1 file)
(deleted),
patch
|
sdwilsh
:
review-
|
Details | Diff | Splinter Review |
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/456c915b3caf
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110524 Firefox/6.0a1 ID:20110524030609
Trailing // should disappear if input text is something like "filxxxx" in the LocationBar
Reproducible: Always
Steps to Reproduce:
1. Start Firefox/6.0a1
2. Open Local file (Ex. file:///D:/localfile.html )
3. Key in LocationBar
fill
Actual Results:
fill//
Expected Results:
fill
Comment 1•13 years ago
|
||
Yeah, this is totally broken. Breaks a number of my bookmark keywords, not to mention opening of actual file:// URIs!
tracking-firefox6:
--- → ?
Comment 2•13 years ago
|
||
(BTW, I don't hit this if I type super-fast. I definitely hit it when typing at the rate of ~2 chars per second, though.)
Updated•13 years ago
|
tracking-firefox6:
--- → ?
Comment 3•13 years ago
|
||
Taking the issue back one step here -- it looks like with "file:///" completions, the suggested portion isn't fully highlighted. The highlighting stops before the final "//" of the suggestion.
So it looks like: file:/// (where 'fi' is what I typed and '^'=highlight)
^^^^
In all other cases I've tested, the *entire* suggested portion is highlighted (and hence deleted when I type another character or hit backspace).
Assignee | ||
Comment 4•13 years ago
|
||
This is caused by not having file:// as one of the valid schemes. Removing http:// from the function causes that to show this behaviour too, strangely...
Assignee: nobody → ventnor.bugzilla
Attachment #535001 -
Flags: review?(sdwilsh)
Comment 5•13 years ago
|
||
Wait. Why do we have some sort of string scheme whitelist/blacklist here? Won't this break for other schemes not in this list too?
Comment 6•13 years ago
|
||
(In reply to comment #5)
> Wait. Why do we have some sort of string scheme whitelist/blacklist here?
> Won't this break for other schemes not in this list too?
Yes, I didn't realize this would be the interaction with other protocols when I reviewed this initially. Need to come up with a better solution here.
Comment 7•13 years ago
|
||
Comment on attachment 535001 [details] [diff] [review]
Patch
Whitelisting is a losing strategy here. What about other protocols like chrome:? Can you please explain how we end up adding the // in there in the first place (I clearly don't understand this code as well as I thought I did)?
Attachment #535001 -
Flags: review?(sdwilsh) → review-
Assignee | ||
Comment 8•13 years ago
|
||
I was doing what Places already does in other parts in JS code. I'm not sure what other strategy we could use.
I'm also not sure why the // is added without the selection, since debugging that code shows CompleteValue getting the expected value and range (up to the first /).
Considering I may need to take a new approach to fix bug 659445, probably backing out the whole thing seems like a good option.
(We can't just turn off the pref as I think I mistakenly removed some important code, see bug 659672)
Comment 10•13 years ago
|
||
don't need to track this for 6 since the feature has been removed for 6.
tracking-firefox6:
? → ---
Updated•13 years ago
|
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•