Closed
Bug 659424
Opened 14 years ago
Closed 14 years ago
Update addons.js module to handle category changes from bug 595848
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression, Whiteboard: [lib])
Attachments
(1 file)
|
(deleted),
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
This will affect our addons.js only for Firefox 6. Bug 595848 has made some changes and broke a large piece of our shared module. We have to get it fixed to ensure we can continue with the discovery pane tests on default and mozilla-aurora.
|
Assignee | |
Updated•14 years ago
|
Summary: Update addons.js module to handle changes from bug 595848 → Update addons.js module to handle category changes from bug 595848
|
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 535089 [details] [diff] [review]
Patch v1
Looks fine. r+
At some point we should maybe discuss whether using magic strings makes sense, or whether we should move stuff like this out into enums/constants.
Attachment #535089 -
Flags: review?(gmealer) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Those strings will not be necessary after the API rewrite when we have the UI map.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Component: Mozmill Tests → Mozmill Shared Modules
|
|
Assignee | |
Updated•13 years ago
|
Component: Mozmill Shared Modules → Mozmill Tests
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [shared module] → [lib]
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•