Closed
Bug 660166
Opened 13 years ago
Closed 13 years ago
Add auroratest channel to supported list of update channels
Categories
(Mozilla QA Graveyard :: Mozmill Automation, defect)
Mozilla QA Graveyard
Mozmill Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(2 files, 3 obsolete files)
(deleted),
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
For the upcoming update tests for Aurora 6.0a2 builds we have to support the new 'auroratest' channel. I will work on it right away.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #535576 -
Flags: review?(anthony.s.hughes)
Assignee | ||
Comment 2•13 years ago
|
||
Last qref was broken. Now the real patch.
Attachment #535576 -
Attachment is obsolete: true
Attachment #535576 -
Flags: review?(anthony.s.hughes)
Attachment #535577 -
Flags: review?(anthony.s.hughes)
Assignee | ||
Comment 3•13 years ago
|
||
We missed to add the supported aurora channels to the testrun_all.py script. This is now included.
Attachment #535577 -
Attachment is obsolete: true
Attachment #535577 -
Flags: review?(anthony.s.hughes)
Attachment #535584 -
Flags: review?(anthony.s.hughes)
Attachment #535584 -
Flags: review?(anthony.s.hughes) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
This has caused a regression in our release_update.py testrun execution:
"UpdateTestRun" object has no attribute _mozmill
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•13 years ago
|
||
This fixes the broken handling of the channel inside the channel-prefs.js file. I talked to Jeff and for the future we will have a utility function to read/write pref files. For now this workaround has to work.
Attachment #536406 -
Flags: review?(jhammel)
Updated•13 years ago
|
Attachment #536406 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 7•13 years ago
|
||
I missed to change group(1) to group(0). With the given regex both will return the same value, but with this change we will be consistent in each usage. Got r+ from Jeff on IRC.
Attachment #536406 -
Attachment is obsolete: true
Attachment #536428 -
Flags: review+
Assignee | ||
Comment 8•13 years ago
|
||
Follow-up fix landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/3363853a5dd4
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
You could also eval in a sandbox, taking advantage that JS and python have similar syntax. Here is a naive implementation:
import re
comment = re.compile('/\*([^*]|[\r\n]|(\*+([^*/]|[\r\n])))*\*+/', re.MULTILINE)
def read(filename):
token = '##//' # magical token
lines = [i.strip() for i in file(filename).readlines() if i.strip()]
retval = {}
_lines = []
for line in lines:
if line.startswith('#'):
continue
if '//' in line:
line = line.replace('//', token)
_lines.append(line)
string = '\n'.join(_lines)
string = re.sub(comment, '', string)
def pref(a, b):
retval[a] = b
lines = [i.strip().rstrip(';') for i in string.split('\n') if i.strip()]
for line in lines:
try:
_globals = {'retval': retval, 'pref': pref, 'user_pref': pref, 'true': True, 'false': False}
eval(line, _globals, {})
except SyntaxError:
print line
import pdb; pdb.set_trace()
for key in retval:
if isinstance(retval[key], basestring) and token in retval[key]:
retval[key] = retval[key].replace(token, '//')
return retval
Updated•10 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•