Closed Bug 66018 Opened 24 years ago Closed 24 years ago

Subscribed Newsgroups and Local Folders migrate, but only appear on 3rd launch.

Categories

(MailNews Core :: Networking: NNTP, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: jay, Assigned: cavin)

References

Details

(Whiteboard: [nsbeta1+])

Attachments

(2 files)

Win98SE - Mozilla Build 2001011904 News servers migrate, groups do not. Only the server names are present after migration, subscribed groups are not, must re-subscribe.
QA Contact: esther → stephend
Are you referring to migration from Netscape 4.7x?
Yes, 4.76 specifically, sorry, I don't usually forget.
yes, I see this too. this is a bad regression. working on a fix now.
Status: NEW → ASSIGNED
all, I see this on linux too. I think I've got the fix for windows, but still debugging why linux is broken.
OS: Windows 98 → All
Hardware: PC → All
I hate this bug. what causes this is probably causing #70494 I've got an idea of what is going on here, upping the priority.
Priority: -- → P1
Target Milestone: --- → mozilla0.9
handing migration bugs over to bhuvan.
Assignee: sspitzer → racham
Status: ASSIGNED → NEW
Priority: P1 → P2
Target Milestone: mozilla0.9 → mozilla0.9.1
Keywords: nsbeta1
Whiteboard: [nsbeta1+]
reassigning to cavin
Assignee: racham → cavin
An update on this, it takes 3 times before I see my subscribed 4.x newsgroups that were migrated into the folder pane. (this is observed with linux and windows 2000 builds, migrated from 4.77).
changing scope of bug to reflect the fact that only on the 3rd launch after doing a mozille.exe -installer (after using 4.x to subscribe to some newsgroups) do we show your subscribed newsgroups.
Summary: Subscribed Newsgroups Fail To Migrate → Subscribed Newsgroups migrate, but only appear on 3rd launch.
Yes, I did see the same behavior and logged it in bug #50567.
Is this dependent on 50567? 50567 is originally about adding an extra Mail or News directory. It seems from Cavin's comments in that bug that we don't handle the situation where we migrate a News or Mail server directory that has been edited from the original directory regardless of whether we add an extra Mail or News directory. If the 4.x user doesn't touch their directories do newsgroups and local folders migrate correctly? I see some comments in http://bugzilla.mozilla.org/show_bug.cgi?id=73768. Are these all dups?
No, in my experience, I never touched paths or directory structures. Simply fired up 4.77, added some newsgroups, shut down. Then ran mozilla.exe -installer and let it grab my 4.77 profile, ran with it, and on the 3rd time it populated my subscribed newsgroup in the folder pane.
The 'directories incorrect' problme in #50567 is one thing to fix but the real problem is that after migration is completed you don't see the migrated folders the first time you run the mail program. If I clicked on the News or Local Folder account in the folder pane (ie, tried to expand the list) then I was able to see the migrated folders (for both news and local folders) the second time I ran the mail program. However, twice I had to run the mail program three times in order to see the migrated folders. #50567 is a separate problem to address and it looks to me that this bug is more important to fix.
*** Bug 73768 has been marked as a duplicate of this bug. ***
adding Local Folders from 73768
Priority: P2 → P1
Summary: Subscribed Newsgroups migrate, but only appear on 3rd launch. → Subscribed Newsgroups and Local Folders migrate, but only appear on 3rd launch.
Patch for fixing 'disappearing local folders and subscribed newsgroups' the very first time mail is launched after migration process is completed is coming.
the nsNewsFolder.cpp fix is good. several of the migration problems will be fixed when we hook the server up to the account after we've set the server's local path, but before we've set the copies and folders prefs for the account's identity. (see bug #31904) I need to double check the patch and make sure we've done that in all cases where we've created an incoming server, including movemail and when we create "Local Folders" when we aren't migrating. (create a new profile, launch mail, or create a new profile, launch msg compose) I'll take a look at those cases on sunday. then I'd like to test this on mac and linux. I think we'll be able to land on monday and then fix #81741
Seth, when you test this patch sunday on linux and mac can you also test #77211 (filter migration bug)) to see it's fixed by this patch. I just tried the patch on windows and it seems to fix #77211. It's related to the folder path setting problem just got fixed. It only happens on POP so just cretae a POP 4.x account, add some filter rules and migrate the account. Thanks.
*** Bug 62576 has been marked as a duplicate of this bug. ***
this fix is looking good on the mac, too. I just want to test linux, and some edge cases. we should be able to land tomorrow.
note to cavin: the two places I fixed were for migrating a movemail account: MigrateMovemailAccount() and for when we create a "Local Folders" account: CreateLocalMailAccount() movemail a UNIX only thing, see http://www.mozilla.org/mailnews/movemail if you are curious. once my linux build is finished, I'll test the patch out. if all goes well, we can land it for 0.9.1
fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
to elaborate: for news, there was one fix to nsNewsFolder.cpp to prevent failure in the the case where there wasn't a folder cache yet. the other part of the fix was to change the order in which we set the servers localpath, the order we set the identity's copies & folder prefs, and the order we hooked up the server and identity to the account. we need to hook the server to the account before setting the copies and folder prefs on the identity (see bug #31904), but after we set the local path on the server.
Verified FIXED, using news.mozilla.org (n.p.mozilla.mail-news), news.webking.com.cn (test, and those international character newsgroups) and with a custom, extra Local Folder of "Foo" all migrated on: Windows 2000 2001-05-23-04 Mac OS 9.1 2001-05-23-08 RedHat 7.0 2001-05-23-08
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: