Closed Bug 660873 Opened 13 years ago Closed 13 years ago

cfx xpi creates corrupted add-ons for packages that have id property without @

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: irakli, Assigned: warner)

Details

Attachments

(1 file)

How likely are folks to set directories.lib to "."? Is this something we advertise/encourage or more an undocumented feature of our new package resolution code?
Whiteboard: [triage:followup]
People have been asking for that, also that's only way npm works today. So if you want to create cross engine package that's only way to go with. Also note that it's not only fails if directories.lib is "." but if you specify `main` that is not in lib folder.
So it looks like issue is not caused by `directories.lib` it is cause by 'id' property of the package json. cuddlefish does not appends `@jetpack` to it that makes package invalid. Also if one will put `@` into id this won't help as cuttlefish has some other issue with that don't yet know what. In any case this significantly lowers priority of this one.
Attachment #536618 - Flags: review?(warner-bugzilla)
Priority: -- → P2
Whiteboard: [triage:followup]
Target Milestone: --- → 1.0
Irakli: should we update the title of this bug? Sounds like it doesn't have anything to di with directories.lib now. Also it sounds related to Bug 661929.
Summary: cfx xpi creates corrupted add-ons if directories.lib is '.' → cfx xpi creates corrupted add-ons for packages that have id property without @
Is this resolved by the changes that went into Bug 661929? Maybe we can close this as a dup now.
Comment on attachment 536618 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/178 This was obsoleted by the code that landed for bug 661929.
Attachment #536618 - Flags: review?(warner-bugzilla) → review-
(automatic reprioritization of 1.0 bugs)
Priority: P2 → P1
Target Milestone: 1.0 → 1.1
Assignee: nobody → warner-bugzilla
I *think* this is no longer relevant, due to the bug 661929 change. Please feel free to re-open if I'm wrong.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: