Closed
Bug 661091
Opened 13 years ago
Closed 13 years ago
iQ.animate: only animate properties that are changing
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 7
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
raymondlee
:
feedback+
|
Details | Diff | Splinter Review |
> this.css({
> '-moz-transition-property': 'all', // TODO: just animate the properties we're changing
> '-moz-transition-duration': (duration / 1000) + 's',
> '-moz-transition-timing-function': easing
> });
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #536531 -
Flags: feedback?(raymond)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 536531 [details] [diff] [review]
patch v1
Looks good
Attachment #536531 -
Flags: feedback?(raymond) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #536531 -
Flags: review?(sdwilsh)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 536531 [details] [diff] [review]
patch v1
r=sdwilsh
Attachment #536531 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
|
|
Assignee | |
Comment 5•13 years ago
|
||
Backed out because this breaks sequential iQ.animate() calls. If we call .fadeIn() and then .setBounds() it interrupts the fading animation and starts the bounds animation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•13 years ago
|
Assignee: tim.taubert → nobody
Target Milestone: Firefox 7 → ---
|
||
Comment 6•13 years ago
|
||
Backed out the back out since it caused a Moth failure on Linux64 opt: http://hg.mozilla.org/integration/mozilla-inbound/rev/b4f654c5f999
|
|
Assignee | |
Comment 7•13 years ago
|
||
Re-marking as fixed.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → tim.taubert
Target Milestone: --- → Firefox 7
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•