Closed Bug 661239 Opened 14 years ago Closed 13 years ago

New mail notification shown for autosaved drafts

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 7.0

People

(Reporter: protz, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Patch v3
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
Sometimes I receive the new mail notification for mails that have been autosaved in my Drafts folder (IMAP) because I have a compose window open and it auto-saves the draft. I don't think these should be shown. Possible fix, but I don't know if we want to do that: don't show the new mail alert if the folder that contains the message has nsMsgFolderFlags::Drafts (or nsMsgFolderFlags::Junk as well).
Assignee: nobody → mconley
Blocks: 555536
Keywords: regression
Attached patch Patch v1 (obsolete) (deleted) — — Splinter Review
This patch causes the new mail notification system to ignore folders with the following flags: Drafts, Queue, SentMail, Templates and Junk. I've added some regression tests, and all notification tests still pass.
Attachment #536693 - Flags: review?(dbienvenu)
I believe this will also fix bug 272125 for Linux.
Comment on attachment 536693 [details] [diff] [review] Patch v1 What if the Inbox has one of those flags set? I think you want to make sure that the folder is not the inbox as well.
Attached patch Patch v2 (obsolete) (deleted) — — Splinter Review
Thanks for the review, Bienvenu! We now only filter out the uninteresting folders if the Inbox flag is not set. Regression test added, and all notification tests pass.
Attachment #536693 - Attachment is obsolete: true
Attachment #536693 - Flags: review?(dbienvenu)
Attachment #536702 - Flags: review?(dbienvenu)
Comment on attachment 536702 [details] [diff] [review] Patch v2 I forgot that I can't really run this, not having linux installed. But it looks fine.
Attachment #536702 - Flags: review?(dbienvenu)
Attachment #536702 - Flags: review?(mbanner)
Mike, are you positive that your boolean expression is correct? I think you need parentheses there...
(In reply to comment #1) > This patch causes the new mail notification system to ignore folders with > the following flags: Drafts, Queue, SentMail, Templates and Junk. What about the Archive folder? As suggested here: news://news.mozilla.com:119/mailman.261.1307269328.5956.dev-apps-thunderbird@lists.mozilla.org
Attached patch Patch v3 (deleted) — — Splinter Review
Protz: thanks for the heads up - I've added the parentheses (I assume we were thinking of the same ones?) Peter: I've added the Archive folder flag to the list of folders that we don't notify. Thanks!
Attachment #536702 - Attachment is obsolete: true
Attachment #536702 - Flags: review?(mbanner)
Attachment #537638 - Flags: review?(mbanner)
Yes the parentheses are what I had in mind. Thanks!
Comment on attachment 537638 [details] [diff] [review] Patch v3 Review of attachment 537638 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #537638 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/30308622251c
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: