Closed
Bug 662258
Opened 13 years ago
Closed 13 years ago
GCC warning about BasicThebesLayerBuffer::CreateBuffer getting hidden by ShadowThebesLayerBuffer::CreateBuffer
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: bjacob, Assigned: bjacob)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I get this warning with GCC 4.5.3:
ThebesLayerOGL.cpp
/home/bjacob/mozilla-central-mobile/gfx/layers/basic/BasicLayers.cpp:672: warning: 'virtual already_AddRefed<gfxASurface> mozilla::layers::BasicThebesLayerBuffer::CreateBuffer(gfxASurface::gfxContentType, const nsIntSize&, PRUint32)' was hidden
/home/bjacob/mozilla-central-mobile/gfx/layers/basic/BasicLayers.cpp:2329: warning: by 'virtual already_AddRefed<gfxASurface> mozilla::layers::ShadowThebesLayerBuffer::CreateBuffer(gfxASurface::gfxContentType, const nsIntSize&)'
It doesn't seem dangerous as there are no optional arguments here, so it doesn't seem like this could cause a different method to be called than what is intended, but still, it's worth fixing.
|
Assignee | |
Comment 1•13 years ago
|
||
In ThebesLayerBuffer.h I see:
virtual already_AddRefed<gfxASurface>
CreateBuffer(ContentType aType, const nsIntSize& aSize, PRUint32 aFlags) = 0;
So my understanding is that this method is intended to take a aFlags argument.
Attached patch adds a PRUint32 argument to the method in question; also since it was a dummy method doing nothing, it makes them non-named arguments which will avoid unused-argument warnings.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #537540 -
Flags: review?(roc)
Comment on attachment 537540 [details] [diff] [review]
fix warning
Review of attachment 537540 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #537540 -
Flags: review?(roc) → review+
|
||
Comment 4•13 years ago
|
||
bjacob: looks like you're clear to land this, right?
|
|
||
Updated•13 years ago
|
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
|
||
Comment 5•13 years ago
|
||
Happy for me to land this?
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla9
|
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•