Closed
Bug 662288
Opened 13 years ago
Closed 13 years ago
Implement CSS3 unicode-bidi: plaintext
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: smontagu, Assigned: smontagu)
References
()
Details
(Keywords: dev-doc-complete, rtl)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See also bug 613149
|
||
Comment 1•13 years ago
|
||
+1 to the priority of this, I would love to see this implemented so that we can have 613149 fixed
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: mozilla7 → mozilla9
Comment on attachment 556835 [details] [diff] [review]
Patch
Review of attachment 556835 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/generic/nsBlockFrame.cpp
@@ +3567,5 @@
> + // frame, because the block frame could be split by hard line breaks into
> + // multiple paragraphs with different base direction
> + FramePropertyTable *propTable = aState.mPresContext->PropertyTable();
> + PRUint8 direction = PRUint32(propTable->Get(aLine->mFirstChild,
> + BaseLevelProperty())) & 1;
Can we store this direction in a state bit so we don't have to do a mildly-expensive property get here?
Or condition this on bidi being enabled?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Howzabouts if we move the test on unicode-bidi: plaintext out of BeginLineReflow to the callers, like so?
Attachment #556835 -
Attachment is obsolete: true
Attachment #556835 -
Flags: review?(roc)
Attachment #557016 -
Flags: review?(roc)
Attachment #557016 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Flags: in-testsuite?
Target Milestone: mozilla9 → mozilla10
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite? → in-testsuite+
|
||
Updated•13 years ago
|
Keywords: dev-doc-needed
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 7•13 years ago
|
||
I've updated:
https://developer.mozilla.org/en/CSS/unicode-bidi
https://developer.mozilla.org/en/Firefox_10_for_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•