Closed Bug 662350 Opened 13 years ago Closed 13 years ago

context menu URL detection code does not recognize domains containing a hyphen

Categories

(Firefox :: Menus, defect)

defect
Not set
minor

Tracking

()

VERIFIED DUPLICATE of bug 591953

People

(Reporter: gankov.andrey, Unassigned)

Details

Attachments

(1 obsolete file)

User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 If i select domain name (not link) in text for example qsolution.ru I can open right click menu and i see "open link", "open in new tab" and "open in new window". But when i select open-suse.ru (domain with hyphen), I do not see the above menu items, and i can not open site. Reproducible: Always Steps to Reproduce: 1. In Firefox 2. Select this text in parenthesis (open-suse.ru), right click 3. and see menu Actual Results: menu without "open link", "open in new tab" and "open in new window" Expected Results: menu with "open link", "open in new tab" and "open in new window" as if you selected (mozilla.org)
http://hg.mozilla.org/mozilla-central/rev/c0dbbcfdb583 (bug 515512) added this protocol-less link detection, apparently the "-" is causing it to choke. Boy is that code ever hard to understand!
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
Summary: Firefox do not recognize domains with hyphen for opening through right click → context menu URL detection code does not recognize domains containing a hyphen
Reproduced Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0 Mozilla/5.0 (X11; Linux x86_64; rv:6.0a2) Gecko/20110606 Firefox/6.0a2 Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110606 Firefox/7.0a1
Version: unspecified → Trunk
I noticed that selecting 'foo.com)' is also broken, addressed this as well.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #537627 - Flags: review?(gavin.sharp)
Oops. Will post to bug 591953.
Assignee: dao → nobody
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Attachment #537627 - Attachment is obsolete: true
Attachment #537627 - Flags: review?(gavin.sharp)
(In reply to comment #1) > http://hg.mozilla.org/mozilla-central/rev/c0dbbcfdb583 (bug 515512) added > this protocol-less link detection, apparently the "-" is causing it to > choke. Boy is that code ever hard to understand! I tried to explain it with comments as much as I could, sorry!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: