Open
Bug 662759
Opened 14 years ago
Updated 2 years ago
--enable-tree-freetype option is broken
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: hiro, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
blassey
:
review-
blassey
:
feedback-
|
Details | Diff | Splinter Review |
checking for inttypes.h... yes
checking for sys/int_types.h... no
checking for iwlib.h... yes
checking for posix_fallocate... yes
checking for GL/glx.h... yes
checking for fontconfig/fcfreetype.h... no
configure: error: Can't find header fontconfig/fcfreetype.h.
Reporter | ||
Comment 1•14 years ago
|
||
The option is for Windows Mobile. We should remove it.
I could not attach whole diff file which is including removal of modules/freetype2 directory since the file size is too large to attach here.
Attachment #537972 -
Flags: review?(ted.mielczarek)
Comment 2•14 years ago
|
||
Comment on attachment 537972 [details] [diff] [review]
fix without modules/freetype2 removal
I'd like blassey to sign off on removing this.
Attachment #537972 -
Flags: feedback?(blassey.bugs)
Comment 3•14 years ago
|
||
Comment on attachment 537972 [details] [diff] [review]
fix without modules/freetype2 removal
Android uses in-tree freetype as well and this breaks the Android build. What is the actual bug here? What platform did you try to build on? This used to work on desktop Windows as well, but I wouldn't be surprised that it was broken by the recent refactorings.
Attachment #537972 -
Flags: review?(ted.mielczarek)
Attachment #537972 -
Flags: review-
Attachment #537972 -
Flags: feedback?(blassey.bugs)
Attachment #537972 -
Flags: feedback-
Reporter | ||
Comment 4•14 years ago
|
||
I am sorry that I did not notice in-tree freetype is used for android.
I was trying to build with --enable-tree-freetype option for ia32 on x64 linux.
The error is caused by this changeset http://hg.mozilla.org/mozilla-central/rev/2b24f7e44096
The problem is that FT2_CFLAGS is also used for cheking of fcfreetype.h, but the CFLAGS is set for Makefile so the CFLAGS is not expanded at there.
9160 if test "$USE_FC_FREETYPE"; then
9161 if test "$COMPILE_ENVIRONMENT"; then
9162 _SAVE_CPPFLAGS="$CPPFLAGS"
9163 CPPFLAGS="$CPPFLAGS $FT2_CFLAGS $XCFLAGS"
9164 AC_CHECK_HEADERS(fontconfig/fcfreetype.h, ,
9165 [AC_MSG_ERROR(Can't find header fontconfig/fcfreetype.h.)])
I have no idea to fix this issue except but just removal the configure option (freetype directory and MOZ_TREE_FREETYPE flag remain). Or add ugly hack something like checking MOZ_TREE_FREETYPE at there.
Comment 5•13 years ago
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•