Closed
Bug 662870
Opened 13 years ago
Closed 12 years ago
Use a native rendering for meter elements on MacOS X
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mounir, Assigned: mounir)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
I see three open questions:
- What are the native sizes (for mini, small, regular widgets)?
- Is there a native vertical style?
- There are 4 styles, the most obvious one to use by default is continuous but do we want to allow the authors to use discrete, rating and relevancy ones? I would say not for the moment. Webkit allows that, see http://trac.webkit.org/wiki/Styling%20Form%20Controls
Work in progress patch attached works but don't use native sizes (but progress ones) and don't takes into account vertical widget.
|
Assignee | |
Comment 1•13 years ago
|
||
There are three widget sizes (mini, small and regular) but all of them have the same size (height=16px).
I will write another patch for the vertical meter widget given that there is no native widget for that and I will have to rotate the widget in the implementation.
Attachment #538077 -
Attachment is obsolete: true
Attachment #538255 -
Flags: review?(joshmoz)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review]
|
|
Assignee | |
Comment 2•13 years ago
|
||
Adding a test for RTL meter.
Attachment #538255 -
Attachment is obsolete: true
Attachment #538255 -
Flags: review?(joshmoz)
Attachment #538317 -
Flags: review?(joshmoz)
Attachment #538317 -
Flags: review?(joshmoz) → review?(bgirard)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 538317 [details] [diff] [review]
Patch v1
Review of attachment 538317 [details] [diff] [review]:
-----------------------------------------------------------------
r+
Attachment #538317 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [needs review] → [ready to land][waits for dependencies]
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•