From Firefox Bug 311007 Add onLocationChange2 which distinguishes between same-document and different-document location changes to web progress listeners. We are now getting the following errors on trunk: Error: 'JavaScript component does not have a method named: "onLocationChange2"' when calling method: [nsIWebProgressListener2::onLocationChange2] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED Source file: jar:file:///C:/T1/hg/objdir-sm/mozilla/dist/seamonkey/omni.jar!/components/nsSessionStore.js Line: 2503 ---------- Error: 'JavaScript component does not have a method named: "onLocationChange2"' when calling method: [nsIWebProgressListener2::onLocationChange2] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED Source file: jar:file:///C:/T1/hg/objdir-sm/mozilla/dist/seamonkey/omni.jar!/components/nsSessionStore.js Line: 2668 ---------- Error: 'JavaScript component does not have a method named: "onLocationChange2"' when calling method: [nsIWebProgressListener2::onLocationChange2] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED Source file: chrome://global/content/bindings/browser.xml

> +++ b/suite/common/downloads/uploadProgress.js I haven't tested this bit because I don't have a FTP server to upload to.

(In reply to comment #1) > I haven't tested this bit because I don't have a FTP server to upload to. Web browser persist doesn't send location changes anyway, only state, progress and status changes.

Comment on attachment 538474 [details] [diff] [review] Patch v1.0 Proposed fix. Would you mind changing this the other way around i.e. rename the existing location change handlers and put in dummy forwards for the old names?

> Would you mind changing this the other way around i.e. rename the existing > location change handlers and put in dummy forwards for the old names? Fixed.

I haven't checked whether they are actually cases that need to be adapted... What about browser/nsBrowserStatusHandler.js, mailnews/compose/MsgComposeCommands.js and common/bindings/notification.xml?

Well the first cut I did was to filter only for code that implements nsIWebProgressListener2 and my patches include notification.xml

hrm newsgroups indicate this may be causing updates not to work. Can we get that fixed next?

Pushe to comm-central http://hg.mozilla.org/comm-central/rev/2b1706a6c9f1

Needs to be backed out now that the relevant patch from Bug 311007 has been backed out.

Patchset backed out: http://hg.mozilla.org/comm-central/rev/eca67f146803