Closed
Bug 663709
Opened 13 years ago
Closed 13 years ago
browser_tabview_bug627288.js depends on other tests
Categories
(Firefox Graveyard :: Panorama, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 7
People
(Reporter: dao, Assigned: ttaubert)
References
Details
Attachments
(2 files)
I disabled a bunch of tabview tests in <http://hg.mozilla.org/try/rev/c5c38fdaaeeb>, which caused browser_tabview_bug627288.js to fail:
>TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug627288.js | Test timed out
>TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug627288.js | Console message: Error while loading thumbnail
>--DOMWINDOW == 55 (0x26e21f8) [serial = 1291] [outer = 0x5710710] [url = about:blank]
>--DOMWINDOW == 54 (0x5ceea28) [serial = 1288] [outer = 0x5cbdae0] [url = about:blank]
>--DOMWINDOW == 53 (0x488fc48) [serial = 1286] [outer = 0x4e8bbb0] [url = https://example.com/]
>--DOMWINDOW == 52 (0x566c298) [serial = 1285] [outer = 0x4e8bbb0] [url = https://example.com/browser/browser/base/content/test/tabview/]
>--DOMWINDOW == 51 (0x53fb768) [serial = 1284] [outer = 0x4e8bbb0] [url = https://example.com/browser/browser/base/content/test/tabview/dummy_page.html]
>--DOMWINDOW == 50 (0x482b938) [serial = 1283] [outer = 0x4e8bbb0] [url = http://www.example.com/]
>--DOMWINDOW == 49 (0x486a898) [serial = 1282] [outer = 0x4e8bbb0] [url = http://www.example.com/browser/browser/base/content/test/tabview/dummy_page.html]
>--DOMWINDOW == 48 (0x4bf8858) [serial = 1281] [outer = 0x4e8bbb0] [url = about:blank]
>--DOMWINDOW == 47 (0x35fd078) [serial = 1280] [outer = 0x4e8bbb0] [url = about:blank]
>--DOMWINDOW == 46 (0x5bf9e68) [serial = 1278] [outer = 0x4e25720] [url = about:blank]
>--DOMWINDOW == 45 (0x5e61ff8) [serial = 1277] [outer = 0x4e25720] [url = about:blank]
>--DOMWINDOW == 44 (0x4895688) [serial = 1289] [outer = 0x5cbdae0] [url = http://mochi.test:8888/]
>--DOMWINDOW == 43 (0x5cbdb58) [serial = 1287] [outer = (nil)] [url = http://mochi.test:8888/]
>--DOCSHELL 0x484de20 == 12
>--DOMWINDOW == 42 (0x4e8bc28) [serial = 1279] [outer = (nil)] [url = https://example.com/]
>--DOCSHELL 0x3e69610 == 11
>--DOMWINDOW == 41 (0x4e25798) [serial = 1276] [outer = (nil)] [url = about:blank]
>--DOCSHELL 0x55a2f10 == 10
>--DOMWINDOW == 40 (0x28072a8) [serial = 1264] [outer = (nil)] [url = about:config]
>--DOMWINDOW == 39 (0x4c0ab78) [serial = 1250] [outer = (nil)] [url = about:robots]
>--DOMWINDOW == 38 (0x3467618) [serial = 1273] [outer = (nil)] [url = about:permissions]
>--DOMWINDOW == 37 (0x2679858) [serial = 1267] [outer = (nil)] [url = about:addons]
>--DOMWINDOW == 36 (0x5b1b8d8) [serial = 1253] [outer = (nil)] [url = about:robots]
>--DOMWINDOW == 35 (0x5cf8b48) [serial = 1269] [outer = (nil)] [url = about:addons]
>--DOMWINDOW == 34 (0x4c18468) [serial = 1266] [outer = (nil)] [url = about:config]
>--DOMWINDOW == 33 (0x55c79e8) [serial = 1275] [outer = (nil)] [url = about:permissions]
>INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug627288.js | finished in 30034ms
>TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug627288.js | Found a tab after previous test timed out: http://mochi.test:8888/
http://tinderbox.mozilla.org/showlog.cgi?log=Try/1307893971.1307896910.10791.gz
Reporter | ||
Comment 1•13 years ago
|
||
Reporter | ||
Comment 2•13 years ago
|
||
This doesn't seem to be intermittent. I retriggered the test run, got the same failure.
Reporter | ||
Comment 3•13 years ago
|
||
Also fails locally when I run it on its own.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•13 years ago
|
||
Saving thumbnails is asynchronous (like loading), my bad.
Attachment #538874 -
Flags: feedback?(raymond)
Comment 5•13 years ago
|
||
Comment on attachment 538874 [details] [diff] [review]
patch v1
Looks good to me!
Attachment #538874 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #538874 -
Flags: review?(dietrich)
Comment 6•13 years ago
|
||
Comment on attachment 538874 [details] [diff] [review]
patch v1
Review of attachment 538874 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538874 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 538874 [details] [diff] [review]
patch v1
Passed try:
http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=55190f32865f
Assignee | ||
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
Assignee | ||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•