Closed Bug 663768 Opened 13 years ago Closed 13 years ago

Clean up syncloadservice

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sicking, Assigned: sicking)

References

Details

Attachments

(2 files, 2 obsolete files)

Part 1: Don't use events to detect load-done
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
Part 2: Kill syncload XPCOM service
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
The syncload service currently uses load/error events to figure out when it can stop spinning the event loop. It would be much simpler to simply stop spinning once OnStopRequest is called on the stream listener. Additionally, the syncloadservice implements a scriptable XPCOM service which we don't seem to use anywhere in our code, so we should just nuke it.
Attachment #538829 - Flags: review?(jst)
Attachment #538830 - Attachment is patch: true
Attachment #538830 - Attachment mime type: text/x-patch → text/plain
Attached patch Part 2: Kill syncload XPCOM service (obsolete) (deleted) — — Splinter Review
Nuked and inlined another function since it was only used in one place.
Attachment #538830 - Attachment is obsolete: true
Attachment #538830 - Flags: review?(jst)
Attachment #538833 - Flags: review?(jst)
Erm.. that last patch was borked. This one's correct.
Attachment #538833 - Attachment is obsolete: true
Attachment #538833 - Flags: review?(jst)
Attachment #538829 - Flags: review?(jst) → review+
Attachment #538837 - Flags: review?(jst) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: