Closed Bug 663919 Opened 14 years ago Closed 13 years ago

Search machine icon missing in address field

Categories

(SeaMonkey :: Search, defect)

defect
Not set
normal

Tracking

(seamonkey2.3 fixed, seamonkey2.4 fixed)

RESOLVED FIXED
seamonkey2.5
Tracking Status
seamonkey2.3 --- fixed
seamonkey2.4 --- fixed

People

(Reporter: Glutton.Vidal, Assigned: neil)

References

Details

Attachments

(2 files)

User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110608 Firefox/4.0.1 SeaMonkey/2.1 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110608 Firefox/4.0.1 SeaMonkey/2.1 In older versions (e.g. 2.0.14) You can see the icon of the search machine ... honestly I was used to click on the right search button ... as this was removed I needed a long time till I realized it after using 2.0.14 since a long time again, that I have to click below the address field. This would be clear obvious with the icon(as seen in the modified screen shot) http://img829.imageshack.us/img829/9250/searchmachine.jpg Reproducible: Always Steps to Reproduce: 1. Give in a search word 2.Click below the address field 3.
Version: unspecified → SeaMonkey 2.1 Branch
Image Shack says I need to register to see that pic, but I think I know what you mean.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Strange! I'm not registered there, and use it often for forums without access problems for others.
I live in a country that Image Shack doesn't like.
<RattyAway> NeilAway: Bug 663919 is this intentional or an oversight on our part? <NeilAway> RattyAway: it's completely broken :-( ... So can we fix it Bob?
Attached patch Proposed patch (deleted) — Splinter Review
addEngine used to take an icon string. The iconURI is an nsIURI, not a string, and it may be null, so I null-check it and use its spec if it exists.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #544976 - Flags: review?(iann_bugzilla)
Comment on attachment 544976 [details] [diff] [review] Proposed patch r=me and a=me for any repos that need it.
Attachment #544976 - Flags: review?(iann_bugzilla)
Attachment #544976 - Flags: review+
Attachment #544976 - Flags: approval-comm-beta+
Attachment #544976 - Flags: approval-comm-aurora+
Pushed changeset 24b8803d73c0 to comm-central. Transplant required for comm-aurora and comm-beta, so setting checkin-needed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Version: SeaMonkey 2.1 Branch → Trunk
Target Milestone: --- → seamonkey2.3
Target Milestone: seamonkey2.3 → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: