Closed
Bug 664116
Opened 13 years ago
Closed 13 years ago
AllTabs.jsm needs to remove event listeners from browser windows
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 7
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: memory-leak)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
AllTabs.jsm seems to be one of the culprits keeping closed browser windows around.
Attachment #539178 -
Flags: feedback?(tim.taubert)
|
Assignee | |
Comment 1•13 years ago
|
||
passed tests on try: http://tbpl.mozilla.org/?tree=Try&rev=c86516044ad9
|
|
Assignee | |
Updated•13 years ago
|
Attachment #539178 -
Flags: feedback?(tim.taubert) → review?(dietrich)
|
||
Comment 2•13 years ago
|
||
Uh, we didn't do that? :/ The patch looks good.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #539178 -
Flags: review?(gavin.sharp)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 539178 [details] [diff] [review]
patch
mockEvents seems unnecessary. why not just build realEvents manually and iterate over that? would be a little bit simpler and more readable.
|
|
Assignee | |
Comment 4•13 years ago
|
||
> mockEvents seems unnecessary. why not just build realEvents manually and
> iterate over that? would be a little bit simpler and more readable.
done
Attachment #539178 -
Attachment is obsolete: true
Attachment #539178 -
Flags: review?(gavin.sharp)
Attachment #539178 -
Flags: review?(dietrich)
Attachment #539780 -
Flags: review?(dietrich)
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 539780 [details] [diff] [review]
patch v2
Review of attachment 539780 [details] [diff] [review]:
-----------------------------------------------------------------
thanks! this needs a test still. Tim, what'd be the best way to go about that?
|
|
Assignee | |
Comment 6•13 years ago
|
||
Various existing tabview tests verify that the event registration continues to work (http://tbpl.mozilla.org/?tree=Try&rev=c97acee70c78). I don't think the removal can be verified in a sensible way.
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 539780 [details] [diff] [review]
patch v2
Review of attachment 539780 [details] [diff] [review]:
-----------------------------------------------------------------
ok, r=me!
Attachment #539780 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
|
||
Comment 9•13 years ago
|
||
Could you please provide some simple STRs in order to have this issue verified in QA?
|
|
Assignee | |
Comment 10•13 years ago
|
||
This doesn't need verification.
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•