Closed
Bug 66435
Opened 24 years ago
Closed 23 years ago
address book code leaks |DIR_Server|s
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dbaron, Assigned: Bienvenu)
Details
(Keywords: memory-leak)
When composing a message from a mailto: link, I saw a bunch of allocations
leaked that were allocated at:
PR_Calloc
dir_GetPrefsFrom45Branch(nsVoidArray **, nsVoidArray **)
DIR_GetServerPreferences(nsVoidArray **)
DIR_GetDirServers(void)
DIR_GetDirectories(void)
nsAbDirectory::GetDirList(void)
I'm guessing the problem is here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/addrbook/src/nsDirPrefs.cpp&rev=1.42&mark=3245#3227
where you need to add an additional
else {
DIR_DeleteServer(server);
}
for the case where obsoleteList is null and the allocated server doesn't get
added to either list. (The observed leak could be from somewhere else, but
this code could certainly leak.)
Comment 1•24 years ago
|
||
anyone looking at this? Can we get it fixed before .9?
Comment 2•24 years ago
|
||
Also, in that function, neither the nsVoidArray |obsoleteList| nor |list| are
freed. Am I right in this assumption, Chuang?
Reporter | ||
Comment 3•24 years ago
|
||
They're returned to the caller.
QA Contact: esther → stephend
I believe this might be a dup of bug 103193, as well.
Assignee | ||
Comment 6•23 years ago
|
||
I think this is fixed - probably a dup, like you say.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
With an updated CVS opt build under Purify, I no longer see this.
Verified FIXED.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•