Closed
Bug 664430
Opened 13 years ago
Closed 13 years ago
Make sure PopupManager doesn't keep objects alive after xpcom-shutdown
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
This is not about fixing any real runtime leak, but only to make sure the
objects aren't kept alive on shutdown.
Attachment #539520 -
Flags: review?(enndeakin)
|
||
Comment 1•13 years ago
|
||
There's bug 480191 which suggests more of a cycle collector thing.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → Olli.Pettay
|
|
Assignee | |
Comment 2•13 years ago
|
||
Nothing there suggest a cycle collector thing. Peter just says that something
should break the cycle, and the patch in this bug does that.
|
|
Assignee | |
Comment 3•13 years ago
|
||
But I'll verify if I can reproduce the leak with the patch.
|
|
Assignee | |
Comment 4•13 years ago
|
||
At least with the patch I can't reproduce the leak.
|
|
Assignee | |
Comment 5•13 years ago
|
||
And actually, since popupmanager is a singleton which will stay alive
until shutdown, adding traverse/unlink is effectively the same as
releasing member during xpcom-shutdown.
|
|
||
Updated•13 years ago
|
Attachment #539520 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•