Closed
Bug 664672
Opened 13 years ago
Closed 13 years ago
When a tab has been removed, cut off its link to the browser
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 7
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
In order to release the browser when something is erroneously holding a reference to a removed tab, we should cut off the link between the two.
mochitest-browser-chrome passed on try with this patch.
Attachment #539742 -
Flags: review?(gavin.sharp)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 539742 [details] [diff] [review]
patch
Why null out linkedPanel? It's just an ID.
It's hard to know whether anyone would be depending on tabs keeping their browsers alive, but I guess there isn't much to do aside from trying it and seeing what breaks.
Attachment #539742 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
removed the linkedPanel part, added a test
Attachment #539742 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•