Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Description • 13 years ago

+++ This bug was initially created as a clone of Bug #636035 +++

Bug 636035 adds the capability to specify own preferences via the command line or a file. Further work has to be done as specified by Jeff below:

> There are a few things here.  Most importantly, this fix does not change the
> default preferences in e.g. FirefoxProfile:
> https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/
> profile.py#L172 . These are still there in unaltered form.
> 
> I believe that these *should* be refactored.  As you said, we care about the
> minimum prefs required to get *Mozmill* working properly.  Strictly
> speaking, mozprofile does not know about mozmill.  While they are in the
> same repository, this is an arbitrary convenience. There is a one-way
> dependency of Mozmill on mozprofile but not vice-versa and....we should not
> have implicit dependencies.  Mozprofile is already used in other projects,
> so its important that we don't put mozmill-specifics in it that are
> undesirable for other code.
> 
> IMHO, FirefoxProfile and ThunderbirdProfile should (at least as they stand)
> probably just go away and the desired preferences for running be provided by
> FirefoxRunner and ThunderbirdRunner. Additional Mozmill-specific preferences
> could be sent down the chain by Mozmill itself.

	Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Comment 1 • 13 years ago

Renaming summary so we do not get threading issues.

	Jeff Hammel
	Comment 2 • 11 years ago

Going to close as a dupe instead of blocking bug 830430 . The more actionable work is outlined there.  IMHO, whatever that bug doesn't covered should be reticketed.