Closed
Bug 665978
Opened 13 years ago
Closed 13 years ago
Delete old .gcda / .pgd files during NSPR PROFILE_GENERATE phase
Categories
(NSPR :: NSPR, defect)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.8.9
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
(Whiteboard: [fixed in nspr])
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Bug 659942 fixed this for everywhere save NSPR, but we should also fix it for NSPR, even though I doubt that fixing this bug will fix bug 653961.
Patch in a moment.
|
Assignee | |
Comment 1•13 years ago
|
||
This is kind of a hack; it always deletes both .gcda and .pgd files, because I
wasn't sure how to properly detect GCC (GNU_CC is not defined). I don't think
that's a big deal, but I'm happy to change it.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #540823 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: wtc → justin.lebar+bug
|
|
Assignee | |
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 2•13 years ago
|
||
Comment on attachment 540823 [details] [diff] [review]
Patch v1
Review of attachment 540823 [details] [diff] [review]:
-----------------------------------------------------------------
::: nsprpub/config/rules.mk
@@ +382,5 @@
> +# Clean up profiling data during PROFILE_GENERATE phase
> +export::
> + -$(RM) *.pgd *.gcda
> +endif
> +
This should be fine, since $(RM) is "rm -f", so removing things that aren't there isn't harmful.
Attachment #540823 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs checkin to NSPR]
|
|
||
Comment 3•13 years ago
|
||
Checking in config/rules.mk;
/cvsroot/mozilla/nsprpub/config/rules.mk,v <-- rules.mk
new revision: 3.81; previous revision: 3.80
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.9
|
||
Updated•13 years ago
|
Target Milestone: 4.9 → 4.8.9
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs checkin to NSPR] → [fixed in nspr]
You need to log in
before you can comment on or make changes to this bug.
Description
•