Closed Bug 66628 Opened 24 years ago Closed 23 years ago

clean up the XULSortService to use the tree batching API

Categories

(Core Graveyard :: RDF, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: sspitzer, Assigned: waterson)

References

Details

Attachments

(1 file)

as long as TreeBoxObject::BeginBatch() / TreeBoxObject::EndBatch() does the
right thing, we can clean up some of the code in XULSortService::DoSort().

I'll attach a patch.
in that patch, I fixed some warnings, switched over to the tree batching api,
and added some timing code.

while working on mailnews sort performance, I found that timing code very
useful.

accepting, adding dependency on a tree batching bug #66583
Status: NEW → ASSIGNED
Depends on: 66583
well, I have no plans on doing this now.

in mailnews, we are doing the sorting in our view.  giving this to waterson.

feel free to mark this wont fix.
Assignee: sspitzer → waterson
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Keywords: helpwanted
Target Milestone: --- → Future
I'm going to try to fold this in to my work on bug 105783.
Depends on: 105783
Keywords: helpwanted
No longer depends on: 105783
I had this patch in my tree for a bit, but things were acting strangely -- I was
getting crashes when trying to scroll after doing a quicksort on a tree.  I'll
try to investigate at some point.
tree batching? we don't got no stinking tree batching
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
tever is not RDF QA anymore
QA Contact: tever → nobody
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: