Closed
Bug 666439
Opened 13 years ago
Closed 12 years ago
autogenerate Makefile.in dependencies to enhance/replace use of allmakefiles.sh
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 784841
People
(Reporter: joey, Unassigned)
References
Details
allmakefiles.sh is another config element that might benefit from makefile generation. If Makefile.in is added or removed in the sandbox autogeneration or removal of the allmakefiles.sh script as a build dependency would eliminate file maintenance as a potential problem source. %make -f client.mk creating browser/components/places/tests/browser/Makefile creating browser/components/places/tests/perf/Makefile can't read /mozilla/sandbox/gml/browser/components/places/tests/perf/Makefile.in: No such file or directory creating browser/components/privatebrowsing/test/Makefile
Comment 1•13 years ago
|
||
allmakefiles.sh is a performance optimization. I'm happy if we want to develop a way to autogenerate it instead of requiring that it be hand-edited whenever we add/remove a directory, but otherwise I'm not sure if it's incredibly important. People have blanket approval to make changes which match reality.
Reporter | ||
Comment 2•13 years ago
|
||
The contents of allmakefiles.sh will be trivial to generate using the container makefile setup. The only question might be about format and how to access. A shell script can be generated for existing behavior. A raw list of paths could be generated for use by $(shell cat allmakefiles) If only used internally by makefiles output could be formatted as a makefile to be included and avoid shell overhead.
Depends on: 623617
Comment 3•12 years ago
|
||
I have code that uses pymake to traverse Makefile.in's and determine which Makefile's need to be generated. It is very fragile because, well, it needs to evaluate Makefile's to work. When we have variable assignment using := $(shell), it breaks horribly, for example.
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #3) > I have code that uses pymake to traverse Makefile.in's and determine which > Makefile's need to be generated. It is very fragile because, well, it needs > to evaluate Makefile's to work. When we have variable assignment using := > $(shell), it breaks horribly, for example. Can this bug be closed now since the shell makefile lists have been deprecated ?
Comment 5•12 years ago
|
||
Agreed; made redundant by bug 784841.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•